./Tools/Scripts/build-webkit --efl --cmakeargs="-DSHARED_CORE=ON" --minimal fails with this error: /home/ed/git/wk/WebKit/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp:78:98: error: ‘ViewModeInvalid’ is not a member of ‘WebCore::Page’ /home/ed/git/wk/WebKit/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp:79:99: error: ‘ViewModeWindowed’ is not a member of ‘WebCore::Page’ /home/ed/git/wk/WebKit/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp:80:99: error: ‘ViewModeFloating’ is not a member of ‘WebCore::Page’ /home/ed/git/wk/WebKit/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp:81:101: error: ‘ViewModeFullscreen’ is not a member of ‘WebCore::Page’ /home/ed/git/wk/WebKit/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp:82:100: error: ‘ViewModeMaximized’ is not a member of ‘WebCore::Page’ /home/ed/git/wk/WebKit/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp:83:100: error: ‘ViewModeMinimized’ is not a member of ‘WebCore::Page’ make[2]: *** [Source/WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/AssertMatchingEnums.cpp.o] Error 1
Created attachment 196666 [details] Patch
Created attachment 196810 [details] Patch Rebased. Please, review.
Please, review!
Comment on attachment 196810 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196810&action=review LGTM otherwise. > Source/WebKit/efl/ewk/ewk_view.cpp:4258 > +#if ENABLE(VIEW_MODE_CSS_MEDIA) Move macro to inside function in public APIs case. > Source/WebKit/efl/ewk/ewk_view.cpp:-4262 > - Do not touch code unrelated to this patch.
Comment on attachment 196810 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196810&action=review > Source/WebKit/efl/ChangeLog:3 > + [EFL] --minimal build fails with error: âViewModeInvalidâ is not a member of âWebCore::Pageâ One more thing. Characters are broken in bug title.
Created attachment 197403 [details] Patch
Comment on attachment 197403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197403&action=review If you get r+ from reviewer, you don't need to request r? again. You just add reviewer's name to ChangeLog, and then just request cq? > Source/WebKit/efl/ewk/ewk_view.cpp:4264 > +#if ENABLE(VIEW_MODE_CSS_MEDIA) To be consistent in existing functions, I prefer to wrap up all function implementations with macro. http://trac.webkit.org/browser/trunk/Source/WebKit/efl/ewk/ewk_view.cpp#L4430 > Source/WebKit/efl/ewk/ewk_view.cpp:4274 > +#if ENABLE(VIEW_MODE_CSS_MEDIA) ditto
Created attachment 197670 [details] Patch
Created attachment 197672 [details] Patch
Comment on attachment 197672 [details] Patch Reviewer only can set r+. Once you get r+ from reviewer, just request cq. Please do not touch r field.
Comment on attachment 197672 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197672&action=review > Source/WebKit/efl/ChangeLog:8 > + Wrapped view-mode media related code into #if ENABLE(VIEW_MODE_CSS_MEDIA) Add a new line.
Created attachment 197867 [details] Patch
Comment on attachment 197867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=197867&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:4271 > + return true; It would be return false when this API is turned off.
Created attachment 197932 [details] Patch
Comment on attachment 197932 [details] Patch Clearing flags on attachment: 197932 Committed r148355: <http://trac.webkit.org/changeset/148355>
All reviewed patches have been landed. Closing bug.