Bug 114033 - Prefer prefix ++/-- operators for non-primitive types
Summary: Prefer prefix ++/-- operators for non-primitive types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-05 07:17 PDT by Kangil Han
Modified: 2013-04-05 21:40 PDT (History)
8 users (show)

See Also:


Attachments
Patch (9.32 KB, patch)
2013-04-05 07:25 PDT, Kangil Han
no flags Details | Formatted Diff | Diff
Patch (8.30 KB, patch)
2013-04-05 20:22 PDT, Kangil Han
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2013-04-05 07:17:51 PDT
Prefer prefix ++/-- operators for non-primitive types
Comment 1 Kangil Han 2013-04-05 07:25:58 PDT
Created attachment 196629 [details]
Patch
Comment 2 WebKit Commit Bot 2013-04-05 19:19:17 PDT
Comment on attachment 196629 [details]
Patch

Rejecting attachment 196629 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 196629, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
nerNode.cpp
Hunk #1 succeeded at 462 (offset -2 lines).
patching file Source/WebCore/dom/Range.cpp
patching file Source/WebCore/loader/FrameLoader.cpp
patching file Source/WebCore/platform/graphics/gpu/LoopBlinnPathProcessor.cpp
patching file Source/WebCore/rendering/InlineTextBox.cpp
patching file Source/WebCore/xml/XPathFunctions.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-commit-queue.appspot.com/results/17473576
Comment 3 Kangil Han 2013-04-05 20:22:15 PDT
Created attachment 196715 [details]
Patch
Comment 4 WebKit Commit Bot 2013-04-05 21:40:05 PDT
Comment on attachment 196715 [details]
Patch

Clearing flags on attachment: 196715

Committed r147832: <http://trac.webkit.org/changeset/147832>
Comment 5 WebKit Commit Bot 2013-04-05 21:40:07 PDT
All reviewed patches have been landed.  Closing bug.