Bug 114010 - Clean the chromium bits of WebCore's WebDatabase
Summary: Clean the chromium bits of WebCore's WebDatabase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-05 01:23 PDT by Benjamin Poulain
Modified: 2013-04-05 13:50 PDT (History)
2 users (show)

See Also:

Attachments
Patch (52.84 KB, patch)
2013-04-05 01:24 PDT, Benjamin Poulain 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-04-05 01:23:37 PDT 
Clean the chromium bits of WebCore's WebDatabase
Comment 1 Benjamin Poulain 2013-04-05 01:24:08 PDT 
Created attachment 196594 [details]
Patch
Comment 2 Mark Lam 2013-04-05 07:37:42 PDT 
Comment on attachment 196594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196594&action=review

LGTM with the getCachedVersion() issue addressed.  Thanks.

> Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp:-533
> -    return getVersionFromDatabase(actualVersion, true);

We will want to adopt this for WK2 instead of the getCachedVersion() below.
Comment 3 Benjamin Poulain 2013-04-05 11:39:42 PDT 
(In reply to comment #2)
> (From update of attachment 196594 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196594&action=review
> 
> LGTM with the getCachedVersion() issue addressed.  Thanks.
> 
> > Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp:-533
> > -    return getVersionFromDatabase(actualVersion, true);
> 
> We will want to adopt this for WK2 instead of the getCachedVersion() below.

I am not sure what you are asking.

You want to keep dead code around? Or you want to remove the #else part and use the former chromium part?
Comment 4 Mark Lam 2013-04-05 12:56:14 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 196594 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=196594&action=review
> > 
> > LGTM with the getCachedVersion() issue addressed.  Thanks.
> > 
> > > Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp:-533
> > > -    return getVersionFromDatabase(actualVersion, true);
> > 
> > We will want to adopt this for WK2 instead of the getCachedVersion() below.
> 
> I am not sure what you are asking.
> 
> You want to keep dead code around? Or you want to remove the #else part and use the former chromium part?

I meant to say that we should keep the chromium version here and get rid of the other.  In this one case, the chromium version is the correct one to use because of WK2’s needs.
Comment 5 Benjamin Poulain 2013-04-05 13:50:52 PDT 
Committed r147796: <http://trac.webkit.org/changeset/147796>