Bug 113982 - Don't dispatch delayed click if snapshotted plugin was triggered by a click on the label
Summary: Don't dispatch delayed click if snapshotted plugin was triggered by a click o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-04 17:52 PDT by Dean Jackson
Modified: 2013-04-04 18:23 PDT (History)
1 user (show)

See Also:

Attachments
Patch (8.41 KB, patch)
2013-04-04 18:12 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-04-04 17:52:22 PDT 
There was a regression as we moved to the ShadowRoot that started always dispatching the click through to the restarted plugin. Previously, a click on the snapshot banner would not forward the click, even though it restarts the plugin.

<rdar://problem/13320869>
Comment 1 Dean Jackson 2013-04-04 18:12:08 PDT 
Created attachment 196564 [details]
Patch
Comment 2 Tim Horton 2013-04-04 18:15:30 PDT 
Comment on attachment 196564 [details]
Patch

Test case would be nice!
Comment 3 Dean Jackson 2013-04-04 18:21:00 PDT 
Test case temporarily delayed due to another bug. It's coming.
Comment 4 Dean Jackson 2013-04-04 18:23:54 PDT 
Committed r147693: <http://trac.webkit.org/changeset/147693>