Bug 113975 - WebKit should not expose AXSubrole:AXDescriptionList on Mountain Lion as it causes a regression in VoiceOver behavior
Summary: WebKit should not expose AXSubrole:AXDescriptionList on Mountain Lion as it c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Craig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-04 16:27 PDT by James Craig
Modified: 2013-04-15 18:33 PDT (History)
8 users (show)

See Also:

Attachments
patch (6.85 KB, patch)
2013-04-12 13:24 PDT, James Craig 		no flags Details | Formatted Diff | Diff
patch with review feedback (6.67 KB, patch)
2013-04-12 16:10 PDT, James Craig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2013-04-04 16:27:25 PDT 
WebKit should not expose AXSubrole:AXDescriptionList on Mountain Lion as it causes a regression in VoiceOver behavior. 

Should just use the old AXDefinitionList.
Comment 1 Radar WebKit Bug Importer 2013-04-04 16:28:54 PDT 
<rdar://problem/13582264>
Comment 2 James Craig 2013-04-12 13:24:04 PDT 
Created attachment 197879 [details]
patch
Comment 3 chris fleizach 2013-04-12 15:22:50 PDT 
Comment on attachment 197879 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197879&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1759
> +            // fall back to NSAccessibilityDefinitionListSubrole in 10.8 and earlier

you can remove this comment. it is self-evident by reading the code

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1760
> +            #if __MAC_OS_X_VERSION_MIN_REQUIRED < 1090

these macros should start at the beginning of the line
Comment 4 James Craig 2013-04-12 16:10:06 PDT 
Created attachment 197903 [details]
patch with review feedback
Comment 5 WebKit Commit Bot 2013-04-15 18:33:02 PDT 
Comment on attachment 197903 [details]
patch with review feedback

Clearing flags on attachment: 197903

Committed r148484: <http://trac.webkit.org/changeset/148484>
Comment 6 WebKit Commit Bot 2013-04-15 18:33:04 PDT 
All reviewed patches have been landed.  Closing bug.