Bug 113944 - [BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element
Summary: [BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops trav...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-04 11:19 PDT by Andrew Lo
Modified: 2013-04-04 20:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.48 KB, patch)
2013-04-04 11:31 PDT, Andrew Lo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Lo 2013-04-04 11:19:11 PDT
DOMSupport::isFixedPositionOrHasFixedPositionAncestor should continue traversing up the render tree if the render object is a render view with an html element owner, when checking whether an ancestor is fixed position.
Comment 1 Andrew Lo 2013-04-04 11:31:03 PDT
Created attachment 196498 [details]
Patch
Comment 2 Rob Buis 2013-04-04 11:44:02 PDT
Comment on attachment 196498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196498&action=review

Ok.

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:643
> +        if (!currentRenderer->parent() && currentRenderer->isRenderView() && currentRenderer->frame() && currentRenderer->frame()->ownerElement()) {

Not sure if RenderView can have a parent in practice...
Comment 3 WebKit Commit Bot 2013-04-04 20:44:44 PDT
Comment on attachment 196498 [details]
Patch

Clearing flags on attachment: 196498

Committed r147701: <http://trac.webkit.org/changeset/147701>
Comment 4 WebKit Commit Bot 2013-04-04 20:44:46 PDT
All reviewed patches have been landed.  Closing bug.