Bug 113942 - [GTK] Remove the gyp build
Summary: [GTK] Remove the gyp build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-04 10:14 PDT by Martin Robinson
Modified: 2013-04-04 12:25 PDT (History)
3 users (show)

See Also:


Attachments
Patch (70.89 KB, patch)
2013-04-04 10:35 PDT, Martin Robinson
gns: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-04-04 10:14:44 PDT
Gyp is a great build system, but there are a multitude of build system great and terrible in their own way. The original intention of the gyp for GTK+ was to reduce the number of different build systems. The reality of today is that gyp for GTK+ means there is one more instead of one less.
Comment 1 Martin Robinson 2013-04-04 10:35:20 PDT
Created attachment 196493 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-04-04 10:40:53 PDT
Comment on attachment 196493 [details]
Patch

=(
Comment 3 WebKit Review Bot 2013-04-04 12:21:14 PDT
Comment on attachment 196493 [details]
Patch

Rejecting attachment 196493 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 196493, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
bkit-commit-queue
t-queue/Source/WebKit/chromium/v8 --revision 14075 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
55>At revision 14075.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://webkit-commit-queue.appspot.com/results/17448066
Comment 4 Martin Robinson 2013-04-04 12:25:17 PDT
Committed r147663: <http://trac.webkit.org/changeset/147663>