Bug 113939 - AX: Make SVG Group containers accessible elements
Summary: AX: Make SVG Group containers accessible elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-04 09:32 PDT by chris fleizach
Modified: 2013-04-05 14:55 PDT (History)
15 users (show)

See Also:

Attachments
patch (16.63 KB, patch)
2013-04-04 14:16 PDT, chris fleizach 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2013-04-04 09:32:47 PDT 
SVG <g> elements are
1) not exposed in the AX hierarchy
2) do not expose the <title> attribute as descriptive text (well no SVG element does either)
3) do not respond to hit-testing.
Comment 1 chris fleizach 2013-04-04 14:16:20 PDT 
Created attachment 196526 [details]
patch
Comment 2 David Kilzer (:ddkilzer) 2013-04-05 11:12:32 PDT 
Comment on attachment 196526 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196526&action=review

This looks okay to me (just some extremely minor nits below), but I'd like someone with more hit testing knowledge to look at the changes.

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1190
> +    Node* node = this->node();

Technically, if you turn off both SVG and MATHML, this will cause a compiler warning about an unused variable.  In practice, I don't think we'll do either.  :)

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1382
> +    Node* node = this->node();

Ditto.
Comment 3 chris fleizach 2013-04-05 14:55:58 PDT 
Addressed David's comments
http://trac.webkit.org/changeset/147801