Bug 113924 – AX:File upload button has wrong label

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

The file upload button for iOS has the wrong label

[chris fleizach]

Created attachment 196443 [details]
patch

[WebKit Review Bot]

Attachment 196443 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/iphone-simulator/accessibility/file-upload-button-expected.txt', u'LayoutTests/platform/iphone-simulator/accessibility/file-upload-button.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm']" exit_code: 1
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[chris fleizach]

Created attachment 196444 [details]
patch

[David Kilzer (:ddkilzer)]

Comment on attachment 196444 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196444&action=review

r=me, but consider adding a mac layout test (result) as well.

> Source/WebCore/ChangeLog:11
> +        Test: platform/iphone-simulator/accessibility/file-upload-button.html

Shouldn't there be a Mac test as well?  Or a test that runs on both Mac and iOS?

[chris fleizach]

(In reply to comment #4)
> (From update of attachment 196444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196444&action=review
> 
> r=me, but consider adding a mac layout test (result) as well.
> 
> > Source/WebCore/ChangeLog:11
> > +        Test: platform/iphone-simulator/accessibility/file-upload-button.html
> 
> Shouldn't there be a Mac test as well?  Or a test that runs on both Mac and iOS?

We already test this on the Mac with its own layout test. Due to the API differences the right label wasn't coming through for iOS, so it will only affect iOS

Thanks

[chris fleizach]

http://trac.webkit.org/changeset/147660