RESOLVED FIXED 113913
[SOUP] Remove unnecessary explicit keyword in SocketStreamError.h 
https://bugs.webkit.org/show_bug.cgi?id=113913
Summary [SOUP] Remove unnecessary explicit keyword in SocketStreamError.h
Seokju Kwon
Reported 2013-04-03 18:22:07 PDT
Patch to follow.
Attachments
Patch (1.48 KB, patch)
2013-04-03 18:24 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Seokju Kwon
Comment 1 2013-04-03 18:24:57 PDT
Created attachment 196428 [details] Patch
Xan Lopez
Comment 2 2013-04-04 03:57:06 PDT
Comment on attachment 196428 [details] Patch Why is the keyword not needed in this case? Do we want to use it in implicit conversions?
Seokju Kwon
Comment 3 2013-04-04 04:10:55 PDT
(In reply to comment #2) > (From update of attachment 196428 [details]) > Why is the keyword not needed in this case? Do we want to use it in implicit conversions? It seems that c++11 supports for explicit keyword on multi-arg constructor. But normally, we use the C++ keyword explicit for constructors with one argument. So, I have just removed it like other ports.
Xan Lopez
Comment 4 2013-04-05 01:46:15 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 196428 [details] [details]) > > Why is the keyword not needed in this case? Do we want to use it in implicit conversions? > > It seems that c++11 supports for explicit keyword on multi-arg constructor. > But normally, we use the C++ keyword explicit for constructors with one argument. > So, I have just removed it like other ports. It seems the ctor had originally just one argument, but then another was added in r102339 and the explicit keyword was not removed. If you say C++ before 11 does not support explicit multi-argument ctors then I guess it makse sense to remove it, but on the other hand WebKit is slowly moving to c++11 and this seems to be harmless. So no strong opinion here. Martin reviewed the original commit, so maybe he has an opinion.
Chris Dumez
Comment 5 2013-04-05 02:10:52 PDT
Comment on attachment 196428 [details] Patch LGTM.
Seokju Kwon
Comment 6 2013-04-05 06:47:51 PDT
Thanks! xan and cdumez. Martin Robinson : What do you think about it?
Martin Robinson
Comment 7 2013-04-05 11:18:41 PDT
Comment on attachment 196428 [details] Patch I guess we can remove this.
WebKit Commit Bot
Comment 8 2013-04-05 11:40:47 PDT
Comment on attachment 196428 [details] Patch Clearing flags on attachment: 196428 Committed r147769: <http://trac.webkit.org/changeset/147769>
WebKit Commit Bot
Comment 9 2013-04-05 11:40:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.