Patch to follow.
Created attachment 196428 [details] Patch
Comment on attachment 196428 [details] Patch Why is the keyword not needed in this case? Do we want to use it in implicit conversions?
(In reply to comment #2) > (From update of attachment 196428 [details]) > Why is the keyword not needed in this case? Do we want to use it in implicit conversions? It seems that c++11 supports for explicit keyword on multi-arg constructor. But normally, we use the C++ keyword explicit for constructors with one argument. So, I have just removed it like other ports.
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 196428 [details] [details]) > > Why is the keyword not needed in this case? Do we want to use it in implicit conversions? > > It seems that c++11 supports for explicit keyword on multi-arg constructor. > But normally, we use the C++ keyword explicit for constructors with one argument. > So, I have just removed it like other ports. It seems the ctor had originally just one argument, but then another was added in r102339 and the explicit keyword was not removed. If you say C++ before 11 does not support explicit multi-argument ctors then I guess it makse sense to remove it, but on the other hand WebKit is slowly moving to c++11 and this seems to be harmless. So no strong opinion here. Martin reviewed the original commit, so maybe he has an opinion.
Comment on attachment 196428 [details] Patch LGTM.
Thanks! xan and cdumez. Martin Robinson : What do you think about it?
Comment on attachment 196428 [details] Patch I guess we can remove this.
Comment on attachment 196428 [details] Patch Clearing flags on attachment: 196428 Committed r147769: <http://trac.webkit.org/changeset/147769>
All reviewed patches have been landed. Closing bug.