Trivial patch coming in a moment - please feel free to WontFix or cq+ this patch as you prefer. Thanks!
Created attachment 196423 [details] Patch
Comment on attachment 196423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196423&action=review > Source/WebCore/rendering/RenderLayer.h:861 > + // from the StyleResolver code. "Only stacking contexts have non-auto z-index because of code in StyleResolver::adjustRenderStyle" might be nicer, either way mentioning adjustRenderStyle is probably good. I also don't think we usually use Note: in webcore, but I don't have a strong opinion on that.
Created attachment 196424 [details] =Adjusted comment, patch for landing
oops - i meant to do cq+ esphren, can you please r+ again The logic flow of your suggested version felt backwards in my opinion, hope this comment is OK.
(In reply to comment #2) > (From update of attachment 196423 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196423&action=review > > > Source/WebCore/rendering/RenderLayer.h:861 > > + // from the StyleResolver code. > > "Only stacking contexts have non-auto z-index because of code in StyleResolver::adjustRenderStyle" might be nicer, either way mentioning adjustRenderStyle is probably good. I also don't think we usually use Note: in webcore, but I don't have a strong opinion on that. (In reply to comment #4) > oops - i meant to do cq+ esphren, can you please r+ again > > The logic flow of your suggested version felt backwards in my opinion, hope this comment is OK. nah, looks good to me.
Comment on attachment 196424 [details] =Adjusted comment, patch for landing Clearing flags on attachment: 196424 Committed r147600: <http://trac.webkit.org/changeset/147600>
All reviewed patches have been landed. Closing bug.