RESOLVED FIXED Bug 113909
Add comment to clarify isStackingContext() in RenderLayer.h 
https://bugs.webkit.org/show_bug.cgi?id=113909
Summary Add comment to clarify isStackingContext() in RenderLayer.h
Shawn Singh
Reported 2013-04-03 16:36:14 PDT
Trivial patch coming in a moment - please feel free to WontFix or cq+ this patch as you prefer. Thanks!
Attachments
Patch (1.58 KB, patch)
2013-04-03 16:38 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
=Adjusted comment, patch for landing (1.58 KB, patch)
2013-04-03 16:55 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2013-04-03 16:38:39 PDT
Created attachment 196423 [details] Patch
Elliott Sprehn
Comment 2 2013-04-03 16:42:06 PDT
Comment on attachment 196423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196423&action=review > Source/WebCore/rendering/RenderLayer.h:861 > + // from the StyleResolver code. "Only stacking contexts have non-auto z-index because of code in StyleResolver::adjustRenderStyle" might be nicer, either way mentioning adjustRenderStyle is probably good. I also don't think we usually use Note: in webcore, but I don't have a strong opinion on that.
Shawn Singh
Comment 3 2013-04-03 16:55:07 PDT
Created attachment 196424 [details] =Adjusted comment, patch for landing
Shawn Singh
Comment 4 2013-04-03 16:56:01 PDT
oops - i meant to do cq+ esphren, can you please r+ again The logic flow of your suggested version felt backwards in my opinion, hope this comment is OK.
Elliott Sprehn
Comment 5 2013-04-03 16:57:01 PDT
(In reply to comment #2) > (From update of attachment 196423 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196423&action=review > > > Source/WebCore/rendering/RenderLayer.h:861 > > + // from the StyleResolver code. > > "Only stacking contexts have non-auto z-index because of code in StyleResolver::adjustRenderStyle" might be nicer, either way mentioning adjustRenderStyle is probably good. I also don't think we usually use Note: in webcore, but I don't have a strong opinion on that. (In reply to comment #4) > oops - i meant to do cq+ esphren, can you please r+ again > > The logic flow of your suggested version felt backwards in my opinion, hope this comment is OK. nah, looks good to me.
WebKit Review Bot
Comment 6 2013-04-03 18:01:23 PDT
Comment on attachment 196424 [details] =Adjusted comment, patch for landing Clearing flags on attachment: 196424 Committed r147600: <http://trac.webkit.org/changeset/147600>
WebKit Review Bot
Comment 7 2013-04-03 18:01:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.