Bug 113906 - when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com)
Summary: when ARIA button contains a link, label text is ignored (affects main buttons...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-03 16:06 PDT by James Craig
Modified: 2013-04-10 13:44 PDT (History)
9 users (show)

See Also:

Attachments
test case (89 bytes, text/html)
2013-04-03 16:06 PDT, James Craig 		no flags Details
code (6.15 KB, application/octet-stream)
2013-04-08 09:32 PDT, chris fleizach 		no flags Details
patch (7.89 KB, patch)
2013-04-08 09:51 PDT, chris fleizach 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2013-04-03 16:06:38 PDT 
Created attachment 196421 [details]
test case

when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com)

For example, these two buttons have empty AXTitle and AXDescription values. Attached test case.

<div role="button"><a href="#">foo</a></div>
<button><a href="#">foo</a></button>
Comment 1 James Craig 2013-04-03 16:07:39 PDT 
<rdar://problem/13289394>
Comment 2 chris fleizach 2013-04-08 09:32:15 PDT 
Created attachment 196864 [details]
code
Comment 3 chris fleizach 2013-04-08 09:51:20 PDT 
Created attachment 196866 [details]
patch
Comment 4 chris fleizach 2013-04-08 09:51:41 PDT 
Adding Tim to help with review
Comment 5 Tim Horton 2013-04-10 12:51:08 PDT 
Comment on attachment 196866 [details]
patch 

View in context: https://bugs.webkit.org/attachment.cgi?id=196866&action=review

> Source/WebCore/accessibility/AccessibilityObject.h:674
> +    virtual bool isDescendantOfBarrenParent() const { return false; }

This is a bizarre name but it was already in the tree...
Comment 6 chris fleizach 2013-04-10 13:44:47 PDT 
http://trac.webkit.org/changeset/148136