Bug 113902 - [EFL] --minimal build fails because of incorrect usage of GENERATE_THEME in CMakeLists.txt
Summary: [EFL] --minimal build fails because of incorrect usage of GENERATE_THEME in C...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Ed Bartosh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-03 15:07 PDT by Ed Bartosh
Modified: 2013-04-07 16:55 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2013-04-03 15:14 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2013-04-06 02:05 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2013-04-07 13:21 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Bartosh 2013-04-03 15:07:15 PDT 
./Tools/Scripts/build-webkit --efl --cmakeargs="-DSHARED_CORE=ON" --minimal fails with this error:

[Creating forwarding header foScanning dependencies of target DefaultTheme
[  0%] Generating ../../../../../WebCore/platform/efl/DefaultTheme/default.edj
edje_cc: Error. file not found:  -DCURSOR_IMAGE_DIR=/home/ed/git/wk/WebKit/Source/WebCore/Resources.
Usage:
        edje_cc [OPTIONS] input_file.edc [output_file.edj]

Where OPTIONS is one or more of:

-w files.txt             Dump all sources files path into files.txt
-id image/directory      Add a directory to look in for relative path images
-fd font/directory       Add a directory to look in for relative path fonts
-sd sound/directory      Add a directory to look in for relative pathCMakeLists.txt sounds samples
-td temp/directory       Directory to store temporary files
-v                       Verbose output
-no-lossy                Do NOT allow images to be lossy
-no-comp                 Do NOT allow images to be stored with lossless compression
-no-raw                  Do NOT allow images to be stored with zero compression (raw)
-no-save                 Do NOT store the input EDC file in the EDJ file
-min-quality VAL         Do NOT allow lossy images with quality < VAL (0-100)
-max-quality VAL         Do NOT allow lossy images with quality > VAL (0-100)
-Ddefine_val=to          CPP style define to define input macro definitions to the .edc source
-fastcomp                Use a faster compression algorithm (LZ4) (mutually exclusive with -fastdecomp)
-fastdecomp              Use a faster decompression algorithm (LZ4HC) (mutually exclusive with -fastcomp)
-threads                 Compile the edje file using multiple parallel threads (by default)
-nothreads               Compile the edje file using only the main loop
make[2]: *** [WebCore/platform/efl/DefaultTheme/default.edj] Error 255
make[1]: *** [Source/WebCore/platform/efl/DefaultTheme/CMakeFiles/DefaultTheme.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Comment 1 Ed Bartosh 2013-04-03 15:14:35 PDT 
Created attachment 196416 [details]
Patch
Comment 2 Ed Bartosh 2013-04-06 02:05:56 PDT 
Created attachment 196725 [details]
Patch

Rebased. Please, review.
Comment 3 Ed Bartosh 2013-04-07 13:21:07 PDT 
Created attachment 196806 [details]
Patch

Rebased again. Please review.
Comment 4 Patrick R. Gansterer 2013-04-07 16:46:03 PDT 
There is no need to rebase your change all the time as long there is no conflict. ChangeLogs get merged by resolve-ChangeLogs. If you use git there are some infos at http://trac.webkit.org/wiki/UsingGitWithWebKit#WebKitScriptsupportforGit
Comment 5 Patrick R. Gansterer 2013-04-07 16:55:27 PDT 
Committed r147886: <http://trac.webkit.org/changeset/147886>