Bug 113898 - Clean up the occlusion handler registration / unregistration code
Summary: Clean up the occlusion handler registration / unregistration code
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
Depends on:
Reported: 2013-04-03 14:25 PDT by Mark Rowe (bdash)
Modified: 2014-01-05 00:27 PST (History)
1 user (show)

See Also:

Patch v1 (6.26 KB, patch)
2013-04-03 14:27 PDT, Mark Rowe (bdash)
koivisto: review+
Details | Formatted Diff | Diff
Revised patch (6.28 KB, patch)
2013-04-03 15:31 PDT, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2013-04-03 14:25:36 PDT
There's a lot of duplication that can easily be removed.
Comment 1 Mark Rowe (bdash) 2013-04-03 14:27:13 PDT
Created attachment 196409 [details]
Patch v1
Comment 2 Kiran Muppala 2013-04-03 15:10:55 PDT
Comment on attachment 196409 [details]
Patch v1

static const OcclusionNotificationHandler occlusionNotificationHandlers[] = {
 156    { WKOcclusionNotificationTypeApplicationBecameVisible, applicationBecameVisible, "Application Became Visible" },
 157    { WKOcclusionNotificationTypeApplicationBecameOccluded, applicationBecameOccluded, "Application Became Occluded" },
 158    { WKOcclusionNotificationTypeApplicationWindowModificationsStarted, applicationWindowModificationsStarted, "Application Window Modifications Started" },
 159    { WKOcclusionNotificationTypeApplicationWindowModificationsStopped, applicationWindowModificationsStopped, "Application Window Modifications Stopped" },

Minor observation: The registration of visible notification used to precede the occluded notification and the order was reversed for unregistration.  Just a defensive style.  Since the order is now fixed, the log line can be replaced with an ASSERT and eliminate the return statement entirely.
Comment 3 Mark Rowe (bdash) 2013-04-03 15:31:37 PDT
Created attachment 196417 [details]
Revised patch

Revised patch for reference. Removes some unnecessary consts that Darin mentioned to me, and changes the WTFLogAlways to ASSERT_WITH_MESSAGE.
Comment 4 Mark Rowe (bdash) 2014-01-05 00:27:21 PST
This was landed back in r147593.