RESOLVED FIXED 113898
Clean up the occlusion handler registration / unregistration code 
https://bugs.webkit.org/show_bug.cgi?id=113898
Summary Clean up the occlusion handler registration / unregistration code
Mark Rowe (bdash)
Reported 2013-04-03 14:25:36 PDT
There's a lot of duplication that can easily be removed.
Attachments
Patch v1 (6.26 KB, patch)
2013-04-03 14:27 PDT, Mark Rowe (bdash) 		koivisto: review+
DetailsFormatted DiffDiff
Revised patch (6.28 KB, patch)
2013-04-03 15:31 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2013-04-03 14:27:13 PDT
Created attachment 196409 [details] Patch v1
Kiran Muppala
Comment 2 2013-04-03 15:10:55 PDT
Comment on attachment 196409 [details] Patch v1 static const OcclusionNotificationHandler occlusionNotificationHandlers[] = { 156 { WKOcclusionNotificationTypeApplicationBecameVisible, applicationBecameVisible, "Application Became Visible" }, 157 { WKOcclusionNotificationTypeApplicationBecameOccluded, applicationBecameOccluded, "Application Became Occluded" }, 158 { WKOcclusionNotificationTypeApplicationWindowModificationsStarted, applicationWindowModificationsStarted, "Application Window Modifications Started" }, 159 { WKOcclusionNotificationTypeApplicationWindowModificationsStopped, applicationWindowModificationsStopped, "Application Window Modifications Stopped" }, 160}; Minor observation: The registration of visible notification used to precede the occluded notification and the order was reversed for unregistration. Just a defensive style. Since the order is now fixed, the log line can be replaced with an ASSERT and eliminate the return statement entirely.
Mark Rowe (bdash)
Comment 3 2013-04-03 15:31:37 PDT
Created attachment 196417 [details] Revised patch Revised patch for reference. Removes some unnecessary consts that Darin mentioned to me, and changes the WTFLogAlways to ASSERT_WITH_MESSAGE.
Mark Rowe (bdash)
Comment 4 2014-01-05 00:27:21 PST
This was landed back in r147593.
Note You need to log in before you can comment on or make changes to this bug.