Bug 113896 - Empty inline continuations should only get lineboxes if the padding applies to their side of the inline
Summary: Empty inline continuations should only get lineboxes if the padding applies t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-03 13:32 PDT by Robert Hogan
Modified: 2013-04-10 11:55 PDT (History)
7 users (show)

See Also:

Attachments
Reduction (445 bytes, text/html)
2013-04-03 13:32 PDT, Robert Hogan 		no flags Details
Patch (5.20 KB, patch)
2013-04-04 11:56 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Patch (5.31 KB, patch)
2013-04-08 11:00 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2013-04-03 13:32:02 PDT 
Created attachment 196404 [details]
Reduction

.
Comment 1 Robert Hogan 2013-04-03 13:45:12 PDT 
layer at (0,0) size 800x120
  RenderBlock {HTML} at (0,0) size 800x120
    RenderBody {BODY} at (8,16) size 784x96
      RenderBlock {DIV} at (0,36) size 784x60 [bgcolor=#008000]
        RenderBlock (anonymous) at (0,0) size 784x30
          RenderInline {DIV} at (0,0) size 0x30
        RenderBlock (anonymous) at (0,30) size 784x0
          RenderBlock {DIV} at (0,0) size 784x0
        RenderBlock (anonymous) at (0,30) size 784x30
          RenderInline {DIV} at (0,0) size 0x30

I think the problem is that the first anonymous block above has an empty inline element (which gets a linebox). This causes the subsequent anonymous block sibling to shift down.
Comment 2 Robert Hogan 2013-04-04 11:56:08 PDT 
Created attachment 196500 [details]
Patch
Comment 3 Robert Hogan 2013-04-08 11:00:47 PDT 
Created attachment 196871 [details]
Patch
Comment 4 Dave Hyatt 2013-04-10 11:27:01 PDT 
Comment on attachment 196871 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2013-04-10 11:55:07 PDT 
Comment on attachment 196871 [details]
Patch

Clearing flags on attachment: 196871

Committed r148121: <http://trac.webkit.org/changeset/148121>
Comment 6 WebKit Commit Bot 2013-04-10 11:55:11 PDT 
All reviewed patches have been landed.  Closing bug.