Bug 113889 - Web Inspector: InspectorPageAgent::disable unconditionally reenables JavaScript execution
Summary: Web Inspector: InspectorPageAgent::disable unconditionally reenables JavaScri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-03 12:27 PDT by Timothy Hatcher
Modified: 2013-04-03 13:37 PDT (History)
9 users (show)

See Also:

Attachments
Proposed Change (3.96 KB, patch)
2013-04-03 12:31 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-04-03 12:27:53 PDT 
InspectorPageAgent::disable forces JavaScript to be enabled even if the user didn't change it via the protocol.
Comment 1 Timothy Hatcher 2013-04-03 12:31:09 PDT 
Created attachment 196391 [details]
Proposed Change
Comment 2 Joseph Pecoraro 2013-04-03 12:42:04 PDT 
Comment on attachment 196391 [details]
Proposed Change

Maybe the Inspector should be more careful about toggling the setting for the entire frame tree instead of just the main frame. But your change here doesn't change that behavior.
Comment 3 WebKit Review Bot 2013-04-03 13:37:49 PDT 
Comment on attachment 196391 [details]
Proposed Change

Clearing flags on attachment: 196391

Committed r147580: <http://trac.webkit.org/changeset/147580>
Comment 4 WebKit Review Bot 2013-04-03 13:37:52 PDT 
All reviewed patches have been landed.  Closing bug.