Bug 113873 - WinCairo build fails to link.
Summary: WinCairo build fails to link.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-03 06:50 PDT by peavo
Modified: 2013-04-04 23:45 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2013-04-03 07:00 PDT, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-04-03 06:50:10 PDT 
The symbols FrameView::setHeaderHeight(int) and FrameView::setFooterHeight(int) are reported as unresolved externals.
They are only compiled if ACCELERATED_COMPOSITING is used.
Comment 1 peavo 2013-04-03 07:00:59 PDT 
Created attachment 196345 [details]
Patch
Comment 2 peavo 2013-04-03 07:02:05 PDT 
Removed double guards for USE(ACCELERATED_COMPOSITING),
and moved methods out of USE(ACCELERATED_COMPOSITING) guard to fix linker errors.
Comment 3 Brent Fulgham 2013-04-04 23:17:07 PDT 
Comment on attachment 196345 [details]
Patch

R=me
Comment 4 WebKit Commit Bot 2013-04-04 23:45:14 PDT 
Comment on attachment 196345 [details]
Patch

Clearing flags on attachment: 196345

Committed r147713: <http://trac.webkit.org/changeset/147713>
Comment 5 WebKit Commit Bot 2013-04-04 23:45:16 PDT 
All reviewed patches have been landed.  Closing bug.