WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 113864
[Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
https://bugs.webkit.org/show_bug.cgi?id=113864
Summary
[Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
Zeno Albisser
Reported
2013-04-03 03:42:18 PDT
[Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
Attachments
Patch
(3.91 KB, patch)
2013-04-03 03:43 PDT
,
Zeno Albisser
hausmann
: review+
hausmann
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Zeno Albisser
Comment 1
2013-04-03 03:43:40 PDT
Created
attachment 196318
[details]
Patch
Simon Hausmann
Comment 2
2013-04-03 04:20:50 PDT
Comment on
attachment 196318
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=196318&action=review
r=me, but the getter needs to be fixed before landing IMHO
> Tools/ChangeLog:7 > + As long as we instantiate both TestRunner and TestRunnerQt, > + we need a separate getter for the non-Qt TestRunner instance.
ChangeLog shoudl also mention that this moves setDefersLoading at the same time. I think given the size of this patch it's okay if both go in at the same time. Just maybe fix the ChangeLog text before landing :)
> Tools/DumpRenderTree/qt/DumpRenderTreeQt.h:92 > + PassRefPtr<TestRunner> jscTestRunner() const { return m_jscController; }
I think the common pattern is to use PassRefPtr as return value for create functions, but use raw pointers for getters, i.e. TestRunner* jscTestRunner() { return m_jscController.get(); } If the caller wants to keep a ref, then the RefPtr ctor that takes a raw pointer will do the ref. Otherwise I think PassRefPtr doesn't give us anything here.
Zeno Albisser
Comment 3
2013-04-03 09:26:27 PDT
Committed
r147563
: <
http://trac.webkit.org/changeset/147563
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug