Bug 113852 – Refine LOG messages in WebSocket related components

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Takeshi Yoshino]

- LOG messages should contain method names to ease identifying where the event occurred.
- For consistency, make all messages print the pointer of the origin instance.
- Quote UTF8 data in LOG messages.
- For overloaded methods, add the type to clarify which one is run

[Takeshi Yoshino]

Created attachment 196290 [details]
Patch

[Kent Tamura]

Comment on attachment 196290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196290&action=review

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:390
> +        LOG(Network, "WebSocketChannel %p appendToBuffer Buffer overflow (%lu bytes already in receive buffer and appending %lu bytes)", this, static_cast<unsigned long>(m_buffer.size()), static_cast<unsigned long>(len));

appendToBuffer -> appendToBuffer() for consistency?

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:468
> +    LOG(Network, "WebSocketChannel %p startClosingHandshake code=%d m_receivedClosingHandshake=%d", this, m_closing, m_receivedClosingHandshake);

startClosingHandshake -> startClosingHandshake() ?

[Takeshi Yoshino]

Created attachment 196302 [details]
Patch

[Takeshi Yoshino]

(In reply to comment #2)

Thanks for review. Fixed both.

[Takeshi Yoshino]

Created attachment 196314 [details]
Patch

[Takeshi Yoshino]

(In reply to comment #5)

Sorry for last minute fix. Replaced %p in WebSocket.cpp L356 with '%s' as it's printable URL data.

[WebKit Review Bot]

Comment on attachment 196314 [details]
Patch

Clearing flags on attachment: 196314

Committed r147542: <http://trac.webkit.org/changeset/147542>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.