- LOG messages should contain method names to ease identifying where the event occurred.
- For consistency, make all messages print the pointer of the origin instance.
- Quote UTF8 data in LOG messages.
- For overloaded methods, add the type to clarify which one is run
Created attachment 196290 [details]
Comment on attachment 196290 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=196290&action=review
> + LOG(Network, "WebSocketChannel %p appendToBuffer Buffer overflow (%lu bytes already in receive buffer and appending %lu bytes)", this, static_cast<unsigned long>(m_buffer.size()), static_cast<unsigned long>(len));
appendToBuffer -> appendToBuffer() for consistency?
> + LOG(Network, "WebSocketChannel %p startClosingHandshake code=%d m_receivedClosingHandshake=%d", this, m_closing, m_receivedClosingHandshake);
startClosingHandshake -> startClosingHandshake() ?
Created attachment 196302 [details]
(In reply to comment #2)
Thanks for review. Fixed both.
Created attachment 196314 [details]
(In reply to comment #5)
Sorry for last minute fix. Replaced %p in WebSocket.cpp L356 with '%s' as it's printable URL data.
Comment on attachment 196314 [details]
Clearing flags on attachment: 196314
Committed r147542: <http://trac.webkit.org/changeset/147542>
All reviewed patches have been landed. Closing bug.