Bug 113851 - [GStreamer] Virtual modifier for MediaPlayer::simulateAudioInterruption must go
Summary: [GStreamer] Virtual modifier for MediaPlayer::simulateAudioInterruption must go
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 23:35 PDT by Xabier Rodríguez Calvar
Modified: 2013-04-04 08:13 PDT (History)
16 users (show)

See Also:

Attachments
Patch (2.39 KB, patch)
2013-04-04 02:50 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2013-04-02 23:35:19 PDT 
+++ This bug was initially created as a clone of Bug #91611 +++

We need to support the request-state GstMessage in the MediaPlayerPrivateGStreamer backend so as to play/pause our pipeline upon downstream request.

http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstMessage.html#gst-message-new-request-state
Comment 1 Xabier Rodríguez Calvar 2013-04-04 02:50:04 PDT 
Created attachment 196461 [details]
Patch

Removed virtual and added symbol to the filter.
Comment 2 Eric Carlson 2013-04-04 07:52:17 PDT 
Comment on attachment 196461 [details]
Patch

Thanks for the clean-up!
Comment 3 WebKit Review Bot 2013-04-04 08:13:40 PDT 
Comment on attachment 196461 [details]
Patch

Clearing flags on attachment: 196461

Committed r147628: <http://trac.webkit.org/changeset/147628>
Comment 4 WebKit Review Bot 2013-04-04 08:13:44 PDT 
All reviewed patches have been landed.  Closing bug.