It seems like autocorrection has stopped working in DumpRenderTree recently. All tests consistently fail. Somehow WebEditorClient::checkTextOfParagraph is returning different results inside DumpRenderTree; NSTextCheckingTypeSpelling instead of NSTextCheckingTypeCorrection.
<rdar://problem/13564441>
This bug blocks other bugs for autocorrection as we cannot test the feature.
Created attachment 196988 [details] Fixes DRT and improves tests
Comment on attachment 196988 [details] Fixes DRT and improves tests View in context: https://bugs.webkit.org/attachment.cgi?id=196988&action=review r=me since the change looks correct, however: > NSTextCheckingTypeSpelling instead of NSTextCheckingTypeCorrection How does this patch fix what's in bug description? > LayoutTests/ChangeLog:8 > + Remoevd failing expectations from tests that require "mesage" to be corrected to "message". Typo: "Remoeved". > LayoutTests/ChangeLog:10 > + without pixel results (we still dump pixel results to sanity check). Is this what dumpAsText(true) does? In such case, we need a more descriptive way to express this desire.
(In reply to comment #4) > (From update of attachment 196988 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196988&action=review > > r=me since the change looks correct, however: > > > NSTextCheckingTypeSpelling instead of NSTextCheckingTypeCorrection > > How does this patch fix what's in bug description? The problem was that we weren't initializing the NSSpellChecker properly in DumpRenderTree. I'll clarify in the change log. > > LayoutTests/ChangeLog:8 > > + Remoevd failing expectations from tests that require "mesage" to be corrected to "message". > > Typo: "Remoeved". Oops, will fix. > > LayoutTests/ChangeLog:10 > > + without pixel results (we still dump pixel results to sanity check). > > Is this what dumpAsText(true) does? In such case, we need a more descriptive way to express this desire. Yeah, we need to change the interface :( I've been saying this since 2010. Maybe it's a good hackathon idea for the contributor's meeting ;)
Comment on attachment 196988 [details] Fixes DRT and improves tests Attachment 196988 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17634058 New failing tests: platform/mac/editing/spelling/click-autocorrected-word.html platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html platform/mac/editing/spelling/delete-into-autocorrected-word.html platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
Created attachment 197009 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Committed r147994: <http://trac.webkit.org/changeset/147994>
This patch changed DumpRenderTree, but not WebKitTestRunner. Ryosuke, would you be willing to take care of that?
(In reply to comment #9) > This patch changed DumpRenderTree, but not WebKitTestRunner. Ryosuke, would you be willing to take care of that? I think that should be tracked in a separate bug. This bug was specifically for DumpRenderTree. Something has massively regressed in WebKitTestRunner with respect to the spellchecking test infrastructure.