Bug 113846 - [Mac] REGRESSION: Autocorrection doesn't work in DumpRenderTree
Summary: [Mac] REGRESSION: Autocorrection doesn't work in DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar, LayoutTestFailure, Regression
Depends on:
Blocks:
 
Reported: 2013-04-02 22:30 PDT by Ryosuke Niwa
Modified: 2013-08-28 14:17 PDT (History)
8 users (show)

See Also:


Attachments
Fixes DRT and improves tests (613.70 KB, patch)
2013-04-08 20:46 PDT, Ryosuke Niwa
ap: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (1.56 MB, application/zip)
2013-04-09 00:27 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-02 22:30:48 PDT
It seems like autocorrection has stopped working in DumpRenderTree recently. All tests consistently fail.

Somehow WebEditorClient::checkTextOfParagraph is returning different results inside DumpRenderTree; NSTextCheckingTypeSpelling instead of NSTextCheckingTypeCorrection.
Comment 1 Radar WebKit Bug Importer 2013-04-02 22:31:26 PDT
<rdar://problem/13564441>
Comment 2 Ryosuke Niwa 2013-04-02 22:32:14 PDT
This bug blocks other bugs for autocorrection as we cannot test the feature.
Comment 3 Ryosuke Niwa 2013-04-08 20:46:04 PDT
Created attachment 196988 [details]
Fixes DRT and improves tests
Comment 4 Alexey Proskuryakov 2013-04-08 22:47:59 PDT
Comment on attachment 196988 [details]
Fixes DRT and improves tests

View in context: https://bugs.webkit.org/attachment.cgi?id=196988&action=review

r=me since the change looks correct, however:

> NSTextCheckingTypeSpelling instead of NSTextCheckingTypeCorrection

How does this patch fix what's in bug description?

> LayoutTests/ChangeLog:8
> +        Remoevd failing expectations from tests that require "mesage" to be corrected to "message".

Typo: "Remoeved".

> LayoutTests/ChangeLog:10
> +        without pixel results (we still dump pixel results to sanity check).

Is this what dumpAsText(true) does? In such case, we need a more descriptive way to express this desire.
Comment 5 Ryosuke Niwa 2013-04-08 23:12:49 PDT
(In reply to comment #4)
> (From update of attachment 196988 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196988&action=review
> 
> r=me since the change looks correct, however:
> 
> > NSTextCheckingTypeSpelling instead of NSTextCheckingTypeCorrection
> 
> How does this patch fix what's in bug description?

The problem was that we weren't initializing the NSSpellChecker properly in DumpRenderTree. I'll clarify in the change log.

> > LayoutTests/ChangeLog:8
> > +        Remoevd failing expectations from tests that require "mesage" to be corrected to "message".
> 
> Typo: "Remoeved".

Oops, will fix.

> > LayoutTests/ChangeLog:10
> > +        without pixel results (we still dump pixel results to sanity check).
> 
> Is this what dumpAsText(true) does? In such case, we need a more descriptive way to express this desire.

Yeah, we need to change the interface :( I've been saying this since 2010. Maybe it's a good hackathon idea for the contributor's meeting ;)
Comment 6 Build Bot 2013-04-09 00:27:26 PDT
Comment on attachment 196988 [details]
Fixes DRT and improves tests

Attachment 196988 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17634058

New failing tests:
platform/mac/editing/spelling/click-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
platform/mac/editing/spelling/delete-into-autocorrected-word.html
platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
Comment 7 Build Bot 2013-04-09 00:27:28 PDT
Created attachment 197009 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 8 Ryosuke Niwa 2013-04-09 00:33:58 PDT
Committed r147994: <http://trac.webkit.org/changeset/147994>
Comment 9 Alexey Proskuryakov 2013-08-28 14:03:19 PDT
This patch changed DumpRenderTree, but not WebKitTestRunner. Ryosuke, would you be willing to take care of that?
Comment 10 Ryosuke Niwa 2013-08-28 14:17:06 PDT
(In reply to comment #9)
> This patch changed DumpRenderTree, but not WebKitTestRunner. Ryosuke, would you be willing to take care of that?

I think that should be tracked in a separate bug. This bug was specifically for DumpRenderTree. Something has massively regressed in WebKitTestRunner with respect to the spellchecking test infrastructure.