Bug 113838 - Compositing tests failing after http://trac.webkit.org/changeset/147502
Summary: Compositing tests failing after http://trac.webkit.org/changeset/147502
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Vujovic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 17:22 PDT by Dean Jackson
Modified: 2013-04-03 12:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.49 KB, patch)
2013-04-03 10:09 PDT, Max Vujovic 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Dean Jackson 2013-04-02 17:27:31 PDT 
Skipping in https://trac.webkit.org/r147510
Comment 2 Max Vujovic 2013-04-02 21:51:08 PDT 
(In reply to comment #1)
> Skipping in https://trac.webkit.org/r147510

Thanks Dean! I forgot to update the expectations to contain "(contentsOpaque 1)" due to bug 108656.

I'll commit new baselines tomorrow.
Comment 3 Max Vujovic 2013-04-03 10:09:04 PDT 
Created attachment 196368 [details]
Patch

The bug that added (contentsOpaque 1) recently was actually bug 70634. I updated the expectations for these tests in bug 109098 before that change landed and not after. Mac WK2 EWS was borked recently so we didn't see the failures until now.
Comment 4 Dean Jackson 2013-04-03 12:40:18 PDT 
Thanks Max!!
Comment 5 Max Vujovic 2013-04-03 12:48:39 PDT 
Comment on attachment 196368 [details]
Patch

No problem. Thanks Dean!
Comment 6 WebKit Review Bot 2013-04-03 12:52:20 PDT 
Comment on attachment 196368 [details]
Patch

Clearing flags on attachment: 196368

Committed r147577: <http://trac.webkit.org/changeset/147577>
Comment 7 WebKit Review Bot 2013-04-03 12:52:23 PDT 
All reviewed patches have been landed.  Closing bug.