Bug 113827 - Use cross-port testRunner methods in fast/loader/url-selected-user-gesture.html
Summary: Use cross-port testRunner methods in fast/loader/url-selected-user-gesture.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 113930
  Show dependency tree / graph
 
Reported: 2013-04-02 14:43 PDT by jochen
Modified: 2013-04-04 02:15 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2013-04-02 14:43 PDT, jochen 		no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2013-04-02 14:52 PDT, jochen 		no flags Details | Formatted Diff | Diff
Patch (2.61 KB, patch)
2013-04-02 15:00 PDT, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-04-02 14:43:15 PDT 
Use cross-port testRunner methods in fast/loader/url-selected-user-gesture.html
Comment 1 jochen 2013-04-02 14:43:30 PDT 
Created attachment 196230 [details]
Patch
Comment 2 jochen 2013-04-02 14:52:10 PDT 
Created attachment 196231 [details]
Patch
Comment 3 Benjamin Poulain 2013-04-02 14:54:49 PDT 
Comment on attachment 196231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196231&action=review

> LayoutTests/fast/loader/url-selected-user-gesture.html:19
> +        if (testRunner.windowCount() == numWindows)
> +            testPassed('no new window opened');
> +        else
> +            testFailed('new window was created');
> +    }

If you rename "numWindows" to -> "originalWindowCount"
You can just have
shoudlBe('testRunner.windowCount()', 'originalWindowCount');
Comment 4 jochen 2013-04-02 15:00:44 PDT 
Created attachment 196233 [details]
Patch
Comment 5 WebKit Review Bot 2013-04-02 15:49:47 PDT 
Comment on attachment 196233 [details]
Patch

Clearing flags on attachment: 196233

Committed r147503: <http://trac.webkit.org/changeset/147503>
Comment 6 WebKit Review Bot 2013-04-02 15:49:50 PDT 
All reviewed patches have been landed.  Closing bug.