Bug 113826 - RenderLayer::paintsWithFilters() is probably wrong without USE(ACCELERATED_COMPOSITING)
Summary: RenderLayer::paintsWithFilters() is probably wrong without USE(ACCELERATED_CO...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 14:39 PDT by Shawn Singh
Modified: 2013-04-02 14:39 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Singh 2013-04-02 14:39:10 PDT 
RenderLayer::paintsWithFilters() -

If USE(ACCELERATED_COMPOSITING) is true, the code makes sense.  But, when USE(ACCELERATED_COMPOSITING) is false, the last return statement should probably be returning true instead.

git blame shows that the code originally existed without the #if guards, and the guards were added later in https://bugs.webkit.org/show_bug.cgi?id=84460 - it seems plausible to me that at that time (april 2012), the USE(ACCELERATED_COMPOSITING) flag was almost always on already, so no bug ever has arisen from it.

Seems like the last return value should be dependent on the value of USE(ACCELERATED_COMPOSITING):

#if USE(ACCELERATED_COMPOSITING)
    return false; // compositor will apply the filters
#else
    return true;  // filters should be handled during paint time.
#endif