Bug 113823 - Generalize prior line break context state and names.
Summary: Generalize prior line break context state and names.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Glenn Adams
URL:
Keywords:
Depends on:
Blocks: 105692
  Show dependency tree / graph
 
Reported: 2013-04-02 13:46 PDT by Glenn Adams
Modified: 2013-04-02 16:27 PDT (History)
9 users (show)

See Also:

Attachments
Patch (12.77 KB, patch)
2013-04-02 14:33 PDT, Glenn Adams 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Glenn Adams 2013-04-02 13:46:20 PDT 
In order to better accommodate an expectation of more general state for prior line break context text and to facilitate use of prior context in non-ASCII line break path, change to a fixed UChar array for storage of prior context and change accessors/methods to use better names.

This change is to simplify (reduce the size of) the patch proposed for bug 105692 in order to ease the review and landing process.

No behavioral change is introduced, so no new tests are required.

Note that it is expected that this prior context state may be further generalized in the future in order to accommodate greater than the last two context characters. This is expected to be required to support Thai (and similar) dictionary based line breaking, where the prior context may consist of an entire word.
Comment 1 Glenn Adams 2013-04-02 14:33:54 PDT 
Created attachment 196227 [details]
Patch
Comment 2 WebKit Review Bot 2013-04-02 16:26:57 PDT 
Comment on attachment 196227 [details]
Patch

Clearing flags on attachment: 196227

Committed r147506: <http://trac.webkit.org/changeset/147506>
Comment 3 WebKit Review Bot 2013-04-02 16:27:00 PDT 
All reviewed patches have been landed.  Closing bug.