Bug 113819 - fourthTier: FTL should have the equivalent of a ValueRecovery
Summary: fourthTier: FTL should have the equivalent of a ValueRecovery
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 113623
  Show dependency tree / graph
 
Reported: 2013-04-02 12:21 PDT by Filip Pizlo
Modified: 2013-04-02 12:52 PDT (History)
7 users (show)

See Also:

Attachments
the patch (10.19 KB, patch)
2013-04-02 12:26 PDT, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-04-02 12:21:22 PDT 
ValueRecoveries speak of registers. The FTL doesn't speak of registers. Also, the FTL doesn't have to reason about the plethora of places that a value could have been put into; it just needs to know the LLVMValueRef (i.e. LValue).  In fact, the FTL really just needs to speak in terms of values-with-formats - essentially a modestly type-refined LLVM value.
Comment 1 Filip Pizlo 2013-04-02 12:26:45 PDT 
Created attachment 196209 [details]
the patch
Comment 2 Mark Hahnenberg 2013-04-02 12:30:54 PDT 
Comment on attachment 196209 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-04-02 12:52:35 PDT 
Landed in http://trac.webkit.org/changeset/147487