Bug 113809 - [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
Summary: [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 11:10 PDT by Gustavo Noronha (kov)
Modified: 2013-10-08 07:47 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2013-04-02 11:12 PDT, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2013-04-02 11:10:25 PDT 
[GTK] gst-plugins-good fails to build with newer Linux(v4l2)
Comment 1 Gustavo Noronha (kov) 2013-04-02 11:12:46 PDT 
Created attachment 196189 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-04-02 12:32:34 PDT 
One thing to consider: I think the media stream stuff requires v4l2, we need this properly fixed when we start running tests for that.
Comment 3 Philippe Normand 2013-04-02 13:20:39 PDT 
Comment on attachment 196189 [details]
Patch

Ok! Do you know if the v4l2 plugin is already fixed in 1.0.5 or higher?
Comment 4 Gustavo Noronha (kov) 2013-04-02 14:00:25 PDT 
Thanks! It is not, but I understood from this discussion that that will be reverted in the kernel, so I'm not 100% it should be fixed in the v4l2 plugin right away - the discussion also seems to indicate these have never been implemented for real, so it should be a simple fix. I reported it here: https://bugzilla.gnome.org/show_bug.cgi?id=697147
Comment 5 Gustavo Noronha (kov) 2013-04-02 14:39:36 PDT 
From the gnome bug; I guess bumping the gst-plugins-good version to 1.0.6 would work as well, would you prefer that, no strong opinion here?

--- Comment #1 from Tim-Philipp Müller <t.i.m@zen.co.uk> 2013-04-02 21:17:41 UTC ---
I believe this has been fixed already, both in git master and in 1.0.6:


 commit 8e633d2059cb835448021cf79becb487aff10975
 Author: Bastien Nocera <hadess@hadess.net>
 Date:   Mon Mar 18 14:59:35 2013 +0000

    v4l2: fix compilation against newer kernel headers as on FC19
Comment 6 Philippe Normand 2013-04-02 23:22:43 PDT 
I would prefer bumping but that'd require some time to check the media tests with the new version.
Comment 7 Gustavo Noronha (kov) 2013-04-03 05:55:00 PDT 
Makes sense, I'll land this for now, then.
Comment 8 Gustavo Noronha (kov) 2013-04-03 06:10:49 PDT 
Comment on attachment 196189 [details]
Patch

Clearing flags on attachment: 196189

Committed r147546: <http://trac.webkit.org/changeset/147546>
Comment 9 Gustavo Noronha (kov) 2013-04-03 06:10:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Philippe Normand 2013-10-08 07:47:40 PDT 
We should re-enable this plugin. I indeed need it for mediastream :)