Bug 113809 – [GTK] gst-plugins-good fails to build with newer Linux(v4l2)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gustavo Noronha (kov)]

[GTK] gst-plugins-good fails to build with newer Linux(v4l2)

[Gustavo Noronha (kov)]

Created attachment 196189 [details]
Patch

[Gustavo Noronha (kov)]

One thing to consider: I think the media stream stuff requires v4l2, we need this properly fixed when we start running tests for that.

[Philippe Normand]

Comment on attachment 196189 [details]
Patch

Ok! Do you know if the v4l2 plugin is already fixed in 1.0.5 or higher?

[Gustavo Noronha (kov)]

Thanks! It is not, but I understood from this discussion that that will be reverted in the kernel, so I'm not 100% it should be fixed in the v4l2 plugin right away - the discussion also seems to indicate these have never been implemented for real, so it should be a simple fix. I reported it here: https://bugzilla.gnome.org/show_bug.cgi?id=697147

[Gustavo Noronha (kov)]

From the gnome bug; I guess bumping the gst-plugins-good version to 1.0.6 would work as well, would you prefer that, no strong opinion here?

--- Comment #1 from Tim-Philipp Müller <[e-mail]> 2013-04-02 21:17:41 UTC ---
I believe this has been fixed already, both in git master and in 1.0.6:


 commit 8e633d2059cb835448021cf79becb487aff10975
 Author: Bastien Nocera <[e-mail]>
 Date:   Mon Mar 18 14:59:35 2013 +0000

    v4l2: fix compilation against newer kernel headers as on FC19

[Philippe Normand]

I would prefer bumping but that'd require some time to check the media tests with the new version.

[Gustavo Noronha (kov)]

Makes sense, I'll land this for now, then.

[Gustavo Noronha (kov)]

Comment on attachment 196189 [details]
Patch

Clearing flags on attachment: 196189

Committed r147546: <http://trac.webkit.org/changeset/147546>

[Gustavo Noronha (kov)]

All reviewed patches have been landed.  Closing bug.

[Philippe Normand]

We should re-enable this plugin. I indeed need it for mediastream :)