Bug 113806 - Upstream AudioDestinationIOS.
Summary: Upstream AudioDestinationIOS.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks: 113813
  Show dependency tree / graph
 
Reported: 2013-04-02 10:59 PDT by Jer Noble
Modified: 2013-04-02 13:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch (22.51 KB, patch)
2013-04-02 11:22 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-04-02 10:59:37 PDT 
Upstream AudioDestiantionIOS.
Comment 1 Jer Noble 2013-04-02 11:22:53 PDT 
Created attachment 196191 [details]
Patch
Comment 2 WebKit Review Bot 2013-04-02 11:27:13 PDT 
Attachment 196191 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.h']" exit_code: 1
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:43:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:148:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:149:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:150:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:151:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:152:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:167:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:271:  Use std::min() or std::min<type>() instead of the MIN() macro.  [runtime/max_min_macros] [4]
Total errors found: 8 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jer Noble 2013-04-02 12:33:25 PDT 
The style errors will be resolved in bug 113813.
Comment 4 Eric Carlson 2013-04-02 12:48:41 PDT 
Comment on attachment 196191 [details]
Patch

r=me if you fix the style complaints.
Comment 5 David Kilzer (:ddkilzer) 2013-04-02 13:02:16 PDT 
Comment on attachment 196191 [details]
Patch

r=me if you fix the style issues, either before or after landing.
Comment 6 Alexis Menard (darktears) 2013-04-02 13:12:09 PDT 
Comment on attachment 196191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196191&action=review

> Source/WebCore/ChangeLog:3
> +        Upstream AudioDestiantionIOS.

Please fix.
Comment 7 Jer Noble 2013-04-02 13:23:13 PDT 
(In reply to comment #6)
> (From update of attachment 196191 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196191&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Upstream AudioDestiantionIOS.
> 
> Please fix.

Whoops.  Will do.
Comment 8 Jer Noble 2013-04-02 13:46:02 PDT 
Committed r147493: <http://trac.webkit.org/changeset/147493>