RESOLVED FIXED 113806
Upstream AudioDestinationIOS. 
https://bugs.webkit.org/show_bug.cgi?id=113806
Summary Upstream AudioDestinationIOS.
Jer Noble
Reported 2013-04-02 10:59:37 PDT
Upstream AudioDestiantionIOS.
Attachments
Patch (22.51 KB, patch)
2013-04-02 11:22 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-04-02 11:22:53 PDT
Created attachment 196191 [details] Patch
WebKit Review Bot
Comment 2 2013-04-02 11:27:13 PDT
Attachment 196191 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp', u'Source/WebCore/platform/audio/ios/AudioDestinationIOS.h']" exit_code: 1 Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:43: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:150: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:151: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:167: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:271: Use std::min() or std::min<type>() instead of the MIN() macro. [runtime/max_min_macros] [4] Total errors found: 8 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jer Noble
Comment 3 2013-04-02 12:33:25 PDT
The style errors will be resolved in bug 113813.
Eric Carlson
Comment 4 2013-04-02 12:48:41 PDT
Comment on attachment 196191 [details] Patch r=me if you fix the style complaints.
David Kilzer (:ddkilzer)
Comment 5 2013-04-02 13:02:16 PDT
Comment on attachment 196191 [details] Patch r=me if you fix the style issues, either before or after landing.
Alexis Menard (darktears)
Comment 6 2013-04-02 13:12:09 PDT
Comment on attachment 196191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196191&action=review > Source/WebCore/ChangeLog:3 > + Upstream AudioDestiantionIOS. Please fix.
Jer Noble
Comment 7 2013-04-02 13:23:13 PDT
(In reply to comment #6) > (From update of attachment 196191 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196191&action=review > > > Source/WebCore/ChangeLog:3 > > + Upstream AudioDestiantionIOS. > > Please fix. Whoops. Will do.
Jer Noble
Comment 8 2013-04-02 13:46:02 PDT
Committed r147493: <http://trac.webkit.org/changeset/147493>
Note You need to log in before you can comment on or make changes to this bug.