Bug 113803 - [Mac] [WK2] Crashes in NetworkProcess when canceling loads
Summary: [Mac] [WK2] Crashes in NetworkProcess when canceling loads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks: 113810
  Show dependency tree / graph
 
Reported: 2013-04-02 10:51 PDT by Alexey Proskuryakov
Modified: 2013-04-02 11:39 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (8.96 KB, patch)
2013-04-02 11:02 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-04-02 10:51:01 PDT 
When we cancel an NSURLConnection, we release its delegate (and delegate proxy). But there may already be delegate calls scheduled on operation queue, or even already executing.

<rdar://problem/13551119>
Comment 1 Alexey Proskuryakov 2013-04-02 11:02:58 PDT 
Created attachment 196184 [details]
proposed fix
Comment 2 Darin Adler 2013-04-02 11:06:31 PDT 
Comment on attachment 196184 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=196184&action=review

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:-175
> -    d->m_proxy.adoptNS(wkCreateNSURLConnectionDelegateProxy());

Will we also remove this WebKitSystemInterface function?
Comment 3 Alexey Proskuryakov 2013-04-02 11:35:24 PDT 
Committed <http://trac.webkit.org/changeset/147476>.

> Will we also remove this WebKitSystemInterface function?

Good idea, I didn't think of these. Will make a separate patch.