Bug 113800 – Padding applied twice for empty generated RenderInlines

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

The padding for empty generated content render objects is incorrectly applied twice.

Downstream chromium bug: https://code.google.com/p/chromium/issues/detail?id=225054

[Emil A Eklund]

Created attachment 196168 [details]
Patch

[Levi Weintraub]

Comment on attachment 196168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196168&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:325
> +        if (!isEmptyInline(parentAsRenderInline)) {

So if it's empty, where does the border/padding/margin get added?

[Emil A Eklund]

(In reply to comment #2)
> (From update of attachment 196168 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196168&action=review
> 
> > Source/WebCore/rendering/RenderBlockLineLayout.cpp:325
> > +        if (!isEmptyInline(parentAsRenderInline)) {
> 
> So if it's empty, where does the border/padding/margin get added?

To the RenderInline instead of the child RenderText

[Levi Weintraub]

Comment on attachment 196168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196168&action=review

LGTM.

> LayoutTests/fast/css-generated-content/margin-empty-content-expected.html:5
> +            ul {
> +                list-style-type: none;

Lookit all the whitespace!

[WebKit Review Bot]

Comment on attachment 196168 [details]
Patch

Clearing flags on attachment: 196168

Committed r147505: <http://trac.webkit.org/changeset/147505>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.