Bug 113798 – Web Inspector: [REGRESSION(r147117)][Elements] Copy/paste keyboard shortcuts broken in "Edit as HTML"

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/147117 broke the build:
This patch breaks copy/paste keyboard shortcuts in Edit as HTML in Elements panel (Requested by alph on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 196164 [details]
ROLLOUT of r147117

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Alexander Pavlov (apavlov)]

Comment on attachment 196164 [details]
ROLLOUT of r147117

I'm preparing a fix.

[Alexander Pavlov (apavlov)]

Created attachment 196198 [details]
Patch

[Pavel Feldman]

Comment on attachment 196198 [details]
Patch

I think editor should stop propagation of these events instead.

[Alexander Pavlov (apavlov)]

Created attachment 196211 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 196211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196211&action=review

> Source/WebCore/inspector/front-end/UIUtils.js:460
> +        element.addEventListener("copy", consumeCopy, true);

Should "copy" event listener be added/removed in WebInspector.CodeMirrorCSSLoadView show/detach? Or do we want to handle copy event in other places?

[Alexander Pavlov (apavlov)]

Comment on attachment 196211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196211&action=review

>> Source/WebCore/inspector/front-end/UIUtils.js:460
>> +        element.addEventListener("copy", consumeCopy, true);
> 
> Should "copy" event listener be added/removed in WebInspector.CodeMirrorCSSLoadView show/detach? Or do we want to handle copy event in other places?

CodeMirrorCSSLoadView is a fake view to handle CSS [un]loading required for the editor. This code is the most low-level one that manages the CodeMirror lifecycle, until we make CodeMirrorTextEditor universal enough to support various kinds of content editing.

[WebKit Review Bot]

Comment on attachment 196211 [details]
Patch

Clearing flags on attachment: 196211

Committed r147535: <http://trac.webkit.org/changeset/147535>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.