Bug 113797 – [Skia] Enable GPU-accelerated Skia path for FEComposite filter.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Stephen White]

[Skia] Enable GPU-accelerated Skia path for FEComposite filter.

[Stephen White]

Created attachment 196163 [details]
Patch

[Adrienne Walker]

Comment on attachment 196163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196163&action=review

R=me, with a few nits.

> Source/WebCore/platform/graphics/filters/skia/FECompositeSkia.cpp:82
> +    typedef SkImageFilter INHERITED;

As a drive-by style comment, defining INHERITED looks a little odd to my eyes.

> LayoutTests/platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt:1
> +layer at (0,0) size 800x600

Is there a reason to have a text dump on either of these tests? They seem entirely like pixel tests.

[Stephen White]

Comment on attachment 196163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196163&action=review

>> Source/WebCore/platform/graphics/filters/skia/FECompositeSkia.cpp:82
>> +    typedef SkImageFilter INHERITED;
> 
> As a drive-by style comment, defining INHERITED looks a little odd to my eyes.

Sorry, it's a skia-ism.  Removed.

>> LayoutTests/platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt:1
>> +layer at (0,0) size 800x600
> 
> Is there a reason to have a text dump on either of these tests? They seem entirely like pixel tests.

I could be wrong, but I don't think there's a way to get pixel-only results:

default:  pixel, rendertree
dumpAsText(true):  pixel, text
dumpAsText(false):  text

[Stephen White]

Created attachment 196177 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 196177 [details]
Patch for landing

Clearing flags on attachment: 196177

Committed r147470: <http://trac.webkit.org/changeset/147470>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.