RESOLVED FIXED 113793
Web Inspector: [CodeMirror] do not show cursor in read-only mode 
https://bugs.webkit.org/show_bug.cgi?id=113793
Summary Web Inspector: [CodeMirror] do not show cursor in read-only mode
Andrey Lushnikov
Reported 2013-04-02 09:08:49 PDT
Do not show cursor in read-only mode.
Attachments
Patch (2.33 KB, patch)
2013-04-02 09:11 PDT, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Patch (1.53 KB, patch)
2013-04-02 10:08 PDT, Andrey Lushnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Lushnikov
Comment 1 2013-04-02 09:11:42 PDT
Created attachment 196156 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2013-04-02 09:22:01 PDT
Comment on attachment 196156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196156&action=review > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:136 > + if (readOnly) Why not just this._codeMirror.setOption("readOnly", isReadOnlySection ? "nocursor" : false); ?
Andrey Lushnikov
Comment 3 2013-04-02 09:43:58 PDT
Comment on attachment 196156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196156&action=review >> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:136 >> + if (readOnly) > > Why not just > > this._codeMirror.setOption("readOnly", isReadOnlySection ? "nocursor" : false); ? yep, your solution is much better! Thanks!
Andrey Lushnikov
Comment 4 2013-04-02 10:08:14 PDT
Created attachment 196171 [details] Patch
Alexander Pavlov (apavlov)
Comment 5 2013-04-02 10:42:52 PDT
Comment on attachment 196171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196171&action=review > Source/WebCore/ChangeLog:8 > + No new tests. We usually specify the reason for which a change has no tests. E.g., "No new tests - a UI change"
WebKit Review Bot
Comment 6 2013-04-02 10:47:56 PDT
Comment on attachment 196171 [details] Patch Clearing flags on attachment: 196171 Committed r147451: <http://trac.webkit.org/changeset/147451>
WebKit Review Bot
Comment 7 2013-04-02 10:47:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.