RESOLVED FIXED Bug 113782
Check whether popups are allowed before creating a new window 
https://bugs.webkit.org/show_bug.cgi?id=113782
Summary Check whether popups are allowed before creating a new window
jochen
Reported 2013-04-02 07:47:27 PDT
Check whether popups are allowed before creating a new window
Attachments
Patch (3.86 KB, patch)
2013-04-02 07:48 PDT, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-04-02 07:48:17 PDT
Created attachment 196139 [details] Patch
WebKit Review Bot
Comment 2 2013-04-02 10:51:39 PDT
Comment on attachment 196139 [details] Patch Clearing flags on attachment: 196139 Committed r147454: <http://trac.webkit.org/changeset/147454>
WebKit Review Bot
Comment 3 2013-04-02 10:51:43 PDT
All reviewed patches have been landed. Closing bug.
Benjamin Poulain
Comment 4 2013-04-02 13:46:43 PDT
Comment on attachment 196139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196139&action=review > LayoutTests/fast/loader/url-selected-user-gesture.html:10 > + testRunner.dumpCreateView(); This only exists on Chromium test runner. The test fails on all the other bots.
jochen
Comment 5 2013-04-02 14:10:01 PDT
(In reply to comment #4) > (From update of attachment 196139 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196139&action=review > > > LayoutTests/fast/loader/url-selected-user-gesture.html:10 > > + testRunner.dumpCreateView(); > > This only exists on Chromium test runner. The test fails on all the other bots. meh, fixing
Note You need to log in before you can comment on or make changes to this bug.