Bug 113782 - Check whether popups are allowed before creating a new window
Summary: Check whether popups are allowed before creating a new window
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 07:47 PDT by jochen
Modified: 2013-04-02 14:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.86 KB, patch)
2013-04-02 07:48 PDT, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-04-02 07:47:27 PDT 
Check whether popups are allowed before creating a new window
Comment 1 jochen 2013-04-02 07:48:17 PDT 
Created attachment 196139 [details]
Patch
Comment 2 WebKit Review Bot 2013-04-02 10:51:39 PDT 
Comment on attachment 196139 [details]
Patch

Clearing flags on attachment: 196139

Committed r147454: <http://trac.webkit.org/changeset/147454>
Comment 3 WebKit Review Bot 2013-04-02 10:51:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Benjamin Poulain 2013-04-02 13:46:43 PDT 
Comment on attachment 196139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196139&action=review

> LayoutTests/fast/loader/url-selected-user-gesture.html:10
> +        testRunner.dumpCreateView();

This only exists on Chromium test runner. The test fails on all the other bots.
Comment 5 jochen 2013-04-02 14:10:01 PDT 
(In reply to comment #4)
> (From update of attachment 196139 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196139&action=review
> 
> > LayoutTests/fast/loader/url-selected-user-gesture.html:10
> > +        testRunner.dumpCreateView();
> 
> This only exists on Chromium test runner. The test fails on all the other bots.

meh, fixing