RESOLVED FIXED 113779
Web Inspector: [Mac/WK1] Provide way to disable docking for the Web Inspector 
https://bugs.webkit.org/show_bug.cgi?id=113779
Summary Web Inspector: [Mac/WK1] Provide way to disable docking for the Web Inspector
Timothy Hatcher
Reported 2013-04-02 06:50:58 PDT
Provide a way to disable the attach button in the Web Inspector and always open in a window. <rdar://problem/13446021>
Attachments
Proposed Change (8.22 KB, patch)
2013-04-02 06:55 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2013-04-02 06:55:32 PDT
Created attachment 196130 [details] Proposed Change
Joseph Pecoraro
Comment 2 2013-04-02 11:24:00 PDT
Comment on attachment 196130 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=196130&action=review > Source/WebKit/cf/ChangeLog:5 > + The user default is "WebKit Web Inspector Setting - inspectorAttachDisabled". This seems good for now. Ideally this could be set, per-WebInspector. > Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp:110 > + storeSetting(inspectorAttachDisabledSetting, disabled ? "true" : "false"); These could be ASCIILiteral("true") and ASCIILiteral("false") (fast path String construction from literals).
WebKit Review Bot
Comment 3 2013-04-02 12:05:05 PDT
Comment on attachment 196130 [details] Proposed Change Clearing flags on attachment: 196130 Committed r147482: <http://trac.webkit.org/changeset/147482>
WebKit Review Bot
Comment 4 2013-04-02 12:05:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.