RESOLVED FIXED Bug 113766
Web Inspector: add tests for grouped messages filtration in console. 
https://bugs.webkit.org/show_bug.cgi?id=113766
Summary Web Inspector: add tests for grouped messages filtration in console.
Dmitry Zvorygin
Reported 2013-04-02 03:25:40 PDT
There was a bug 113327, which wasn't noticed by tests, so tests should be strengthened.
Attachments
Patch (12.56 KB, patch)
2013-04-02 03:30 PDT, Dmitry Zvorygin 		no flags
DetailsFormatted DiffDiff
Patch (12.53 KB, patch)
2013-04-02 04:09 PDT, Dmitry Zvorygin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dmitry Zvorygin
Comment 1 2013-04-02 03:30:04 PDT
Created attachment 196113 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2013-04-02 03:32:47 PDT
Comment on attachment 196113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196113&action=review > LayoutTests/inspector/console/console-filter-test.html:61 > + if (groupMessages[j].hasStyleClass("console-message")) { No braces around single-line blocks > LayoutTests/inspector/console/console-filter-test.html:63 > + } else if (groupMessages[j].hasStyleClass("console-group")) { ditto
Dmitry Zvorygin
Comment 3 2013-04-02 04:09:57 PDT
Created attachment 196120 [details] Patch
Dmitry Zvorygin
Comment 4 2013-04-02 04:27:34 PDT
Comment on attachment 196113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196113&action=review >> LayoutTests/inspector/console/console-filter-test.html:61 >> + if (groupMessages[j].hasStyleClass("console-message")) { > > No braces around single-line blocks Fixed. >> LayoutTests/inspector/console/console-filter-test.html:63 >> + } else if (groupMessages[j].hasStyleClass("console-group")) { > > ditto Fixed.
WebKit Review Bot
Comment 5 2013-04-02 06:44:08 PDT
Comment on attachment 196120 [details] Patch Clearing flags on attachment: 196120 Committed r147424: <http://trac.webkit.org/changeset/147424>
WebKit Review Bot
Comment 6 2013-04-02 06:44:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.