Bug 113766 - Web Inspector: add tests for grouped messages filtration in console.
Summary: Web Inspector: add tests for grouped messages filtration in console.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 03:25 PDT by Dmitry Zvorygin
Modified: 2013-04-02 06:44 PDT (History)
9 users (show)

See Also:

Attachments
Patch (12.56 KB, patch)
2013-04-02 03:30 PDT, Dmitry Zvorygin 		no flags Details | Formatted Diff | Diff
Patch (12.53 KB, patch)
2013-04-02 04:09 PDT, Dmitry Zvorygin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Zvorygin 2013-04-02 03:25:40 PDT 
There was a bug 113327, which wasn't noticed by tests, so tests should be strengthened.
Comment 1 Dmitry Zvorygin 2013-04-02 03:30:04 PDT 
Created attachment 196113 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2013-04-02 03:32:47 PDT 
Comment on attachment 196113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196113&action=review

> LayoutTests/inspector/console/console-filter-test.html:61
> +                    if (groupMessages[j].hasStyleClass("console-message")) {

No braces around single-line blocks

> LayoutTests/inspector/console/console-filter-test.html:63
> +                    } else if (groupMessages[j].hasStyleClass("console-group")) {

ditto
Comment 3 Dmitry Zvorygin 2013-04-02 04:09:57 PDT 
Created attachment 196120 [details]
Patch
Comment 4 Dmitry Zvorygin 2013-04-02 04:27:34 PDT 
Comment on attachment 196113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196113&action=review

>> LayoutTests/inspector/console/console-filter-test.html:61
>> +                    if (groupMessages[j].hasStyleClass("console-message")) {
> 
> No braces around single-line blocks

Fixed.

>> LayoutTests/inspector/console/console-filter-test.html:63
>> +                    } else if (groupMessages[j].hasStyleClass("console-group")) {
> 
> ditto

Fixed.
Comment 5 WebKit Review Bot 2013-04-02 06:44:08 PDT 
Comment on attachment 196120 [details]
Patch

Clearing flags on attachment: 196120

Committed r147424: <http://trac.webkit.org/changeset/147424>
Comment 6 WebKit Review Bot 2013-04-02 06:44:12 PDT 
All reviewed patches have been landed.  Closing bug.