Bug 113743 - Viewport constrained elements should work properly with headers and footers
Summary: Viewport constrained elements should work properly with headers and footers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-04-01 21:14 PDT by Beth Dakin
Modified: 2013-04-02 11:24 PDT (History)
10 users (show)

See Also:

Attachments
Patch (22.96 KB, patch)
2013-04-01 21:25 PDT, Beth Dakin 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-04-01 21:14:10 PDT 
http://trac.webkit.org/changeset/147039 provided API to allow a WebView to have a header and/or footer. position:fixed elements need to work correctly in this mode.

<rdar://problem/13522402>
Comment 1 Beth Dakin 2013-04-01 21:25:10 PDT 
Created attachment 196068 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-04-01 22:15:02 PDT 
Comment on attachment 196068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196068&action=review

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:112
> +    unsigned headerHeight() const { return m_headerHeight; }

int return.

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:115
> +    unsigned footerHeight() const { return m_footerHeight; }

Ditto.

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:161
> +    unsigned m_headerHeight;
> +    unsigned m_footerHeight;

int?

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:77
> +    unsigned headerHeight() const { return m_headerHeight; }
> +    unsigned footerHeight() const { return m_footerHeight; }

ints

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:98
> +    unsigned m_headerHeight;
> +    unsigned m_footerHeight;

ints

> Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h:119
> +        unsigned headerHeight;
> +        unsigned footerHeight;

ints

> LayoutTests/platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:5
> +    <meta name="apple-mobile-web-app-capable" content="yes">

Remove this.

> LayoutTests/platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:47
> +    <script type="text/javascript" charset="utf-8">

No need for the attributes.
Comment 3 Beth Dakin 2013-04-02 11:24:37 PDT 
Thanks, Simon! I fixed the errors you found.

http://trac.webkit.org/changeset/147471