Bug 113743 – Viewport constrained elements should work properly with headers and footers

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Beth Dakin]

http://trac.webkit.org/changeset/147039 provided API to allow a WebView to have a header and/or footer. position:fixed elements need to work correctly in this mode.

<rdar://problem/13522402>

[Beth Dakin]

Created attachment 196068 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 196068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196068&action=review

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:112
> +    unsigned headerHeight() const { return m_headerHeight; }

int return.

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:115
> +    unsigned footerHeight() const { return m_footerHeight; }

Ditto.

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:161
> +    unsigned m_headerHeight;
> +    unsigned m_footerHeight;

int?

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:77
> +    unsigned headerHeight() const { return m_headerHeight; }
> +    unsigned footerHeight() const { return m_footerHeight; }

ints

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:98
> +    unsigned m_headerHeight;
> +    unsigned m_footerHeight;

ints

> Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h:119
> +        unsigned headerHeight;
> +        unsigned footerHeight;

ints

> LayoutTests/platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:5
> +    <meta name="apple-mobile-web-app-capable" content="yes">

Remove this.

> LayoutTests/platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:47
> +    <script type="text/javascript" charset="utf-8">

No need for the attributes.

[Beth Dakin]

Thanks, Simon! I fixed the errors you found.

http://trac.webkit.org/changeset/147471