Bug 113738 - Hide non-coordinated scrollbars for Android M26
Summary: Hide non-coordinated scrollbars for Android M26
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 18:24 PDT by Tien-Ren Chen
Modified: 2013-04-02 08:23 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.88 KB, patch)
2013-04-01 18:27 PDT, Tien-Ren Chen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tien-Ren Chen 2013-04-01 18:24:43 PDT
Hide non-coordinated scrollbars for Android M26
Comment 1 Tien-Ren Chen 2013-04-01 18:27:32 PDT
Created attachment 196050 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-04-01 18:35:48 PDT
Comment on attachment 196050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review

> Source/WebCore/platform/ScrollView.cpp:919
> +#if OS(ANDROID)

This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this.
Comment 3 Tien-Ren Chen 2013-04-01 18:44:33 PDT
(In reply to comment #2)
> (From update of attachment 196050 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review
> 
> > Source/WebCore/platform/ScrollView.cpp:919
> > +#if OS(ANDROID)
> 
> This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this.

It only needs to be landed and then reverted immediately, for our branch management workflow. The cherry-pick script we use needs a WebKit SVN revision number. I don't know if there is a simple workaround to that.
Comment 4 Simon Fraser (smfr) 2013-04-01 20:34:29 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 196050 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review
> > 
> > > Source/WebCore/platform/ScrollView.cpp:919
> > > +#if OS(ANDROID)
> > 
> > This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this.
> 
> It only needs to be landed and then reverted immediately, for our branch management workflow. The cherry-pick script we use needs a WebKit SVN revision number. I don't know if there is a simple workaround to that.

That seems a bit crazy, but OK.
Comment 5 Simon Fraser (smfr) 2013-04-01 20:34:49 PDT
Comment on attachment 196050 [details]
Patch

r+ assuming it's immediately reverted.
Comment 6 Alexandre Elias 2013-04-01 20:41:27 PDT
Comment on attachment 196050 [details]
Patch

Thanks for humoring our strange tools :)
Comment 7 WebKit Review Bot 2013-04-01 23:14:45 PDT
Comment on attachment 196050 [details]
Patch

Clearing flags on attachment: 196050

Committed r147389: <http://trac.webkit.org/changeset/147389>
Comment 8 WebKit Review Bot 2013-04-01 23:14:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Alexandre Elias 2013-04-02 08:23:31 PDT
Reverted r147389 for reason:

Patch specified it should be reverted

Committed r147436: <http://trac.webkit.org/changeset/147436>