Bug 113737 - Make feature_defines.sh work for VS2010
Summary: Make feature_defines.sh work for VS2010
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 18:15 PDT by Roger Fong
Modified: 2013-04-01 22:41 PDT (History)
3 users (show)

See Also:

Attachments
patch (2.48 KB, patch)
2013-04-01 18:23 PDT, Roger Fong 		no flags Details | Formatted Diff | Diff
patch (3.65 KB, patch)
2013-04-01 19:09 PDT, Roger Fong 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-04-01 18:15:04 PDT 
VS2010 build uses a new FeatureDefines.props file with a different format from the original FeatureDefines.vsprops.

The feature defines string outputted by feature-defines.sh needs to be corrected for this.

Also creating a feature_defines2010.sh because we still need both feature_defines scripts for now.
Comment 1 Roger Fong 2013-04-01 18:15:22 PDT 
<rdar://problem/13343147>
Comment 2 Roger Fong 2013-04-01 18:23:22 PDT 
Created attachment 196048 [details]
patch
Comment 3 Roger Fong 2013-04-01 19:09:33 PDT 
Created attachment 196052 [details]
patch
Comment 4 Tim Horton 2013-04-01 19:11:04 PDT 
Comment on attachment 196052 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196052&action=review

> WebKitLibraries/win/tools/scripts/feature-defines2010.sh:3
> +# Copyright (C) 2010 Apple Inc. All rights reserved.

2013
Comment 5 Roger Fong 2013-04-01 22:41:16 PDT 
committed: http://trac.webkit.org/changeset/147375