Bug 113720 – AX: Need to get line thickness from fraction on web

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

For a binomial coefficient, the recommended way of encoding in MathML is to use a fraction and set the line thickness to 0, according to W3.
http://www.w3.org/TR/REC-MathML/chap3_3.html
See the example here:
https://eyeasme.com/Joe/MathML/MathML_browser_test
The MathML is:
<mfenced>
                  <mfrac linethickness="0">
                    <mi>n</mi>
                    <mi>k</mi>
                  </mfrac>
                </mfenced>

[chris fleizach]

rdar://13547806

[chris fleizach]

Created attachment 196025 [details]
patch

[chris fleizach]

Adding Tim to help with review

[David Kilzer (:ddkilzer)]

Comment on attachment 196025 [details]
patch 

View in context: https://bugs.webkit.org/attachment.cgi?id=196025&action=review

r=me

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2008
> +- (NSInteger)accessibilityMathLineThickness
> +{
> +    if (![self _prepareAccessibilityCall])
> +        return 0;

I don't see this check added to some of the -accessibilityMath* methods above.

Is it necessary?  Should all of the methods above have this check as well?

[chris fleizach]

Comment on attachment 196025 [details]
patch 

View in context: https://bugs.webkit.org/attachment.cgi?id=196025&action=review

>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2008
>> +        return 0;
> 
> I don't see this check added to some of the -accessibilityMath* methods above.
> 
> Is it necessary?  Should all of the methods above have this check as well?

Yes they should all have that check. I've been meaning to fix that. I'll upload a new patch for that today. Thanks

[WebKit Review Bot]

Comment on attachment 196025 [details]
patch 

Clearing flags on attachment: 196025

Committed r147439: <http://trac.webkit.org/changeset/147439>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.