Bug 113714 – IndexedDB: Abort transactions of abnormally closed connections

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Joshua Bell]

IndexedDB: Abort transactions of abnormally closed connections

[Joshua Bell]

Created attachment 196004 [details]
Patch

[Joshua Bell]

dgrogan@, alecflett@ - can you take a look?

[David Grogan]

Comment on attachment 196004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196004&action=review

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1323
> +    // if the close is requested by the connection itself, so something unusual has

Why not? Because the frontend won't tell the backend to close while there are still running transactions?

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1324
> +    // happened e.g. abnormal process termination, forced close, etc.

Looks like the transactions should be gone if there was a forced close - IDBDatabase::forceClose aborts all transactions before calling IDBDatabase::close(). Could a forced close really necessitate this?

[Joshua Bell]

(In reply to comment #3)
> (From update of attachment 196004 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196004&action=review
> 
> > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1323
> > +    // if the close is requested by the connection itself, so something unusual has
> 
> Why not? Because the frontend won't tell the backend to close while there are still running transactions?

Exactly. The front end defers actually closing until all transactions have completed.

> > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1324
> > +    // happened e.g. abnormal process termination, forced close, etc.
> 
> Looks like the transactions should be gone if there was a forced close - IDBDatabase::forceClose aborts all transactions before calling IDBDatabase::close(). Could a forced close really necessitate this?

That's true. I'll fix the comment.

[Joshua Bell]

Created attachment 196027 [details]
Patch

[David Grogan]

Comment on attachment 196027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196027&action=review

LGTM

> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:1325
> +    // e.g. unexpected process termination.

Argh, I think my comment on the last patch was wrong. When a forceClose is called, this method is called and then the frontend is notified of the force close. Then the frontend aborts all the transactions, which would be too late. So I think your original comment was correct.

[Levi Weintraub]

Should this be moved to blink? If so, please clear the flags on the patch and mark this bug as invalid.

[Joshua Bell]

I've copied this to blink. The issue/patch is still valid for WebKit. I'm pinging possible new owners.

[Brent Fulgham]

I don't believe this change is relevant to WebKit's newer indexedDB design.