RESOLVED FIXED Bug 113708
Web Inspector: [Timeline] unify logic for 3 overview modes in Timeline 
https://bugs.webkit.org/show_bug.cgi?id=113708
Summary Web Inspector: [Timeline] unify logic for 3 overview modes in Timeline
Andrey Kosyakov
Reported 2013-04-01 10:04:17 PDT
Now that the 3 modes implement a common interface, remove all custom logic in overview pane itself and handle them in a consistent manner.
Attachments
Patch (13.07 KB, patch)
2013-04-01 10:09 PDT, Andrey Kosyakov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2013-04-01 10:09:20 PDT
Created attachment 195984 [details] Patch
Yury Semikhatsky
Comment 2 2013-04-02 07:07:52 PDT
Comment on attachment 195984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195984&action=review > Source/WebCore/inspector/front-end/TimelineOverviewPane.js:148 > + return null; Why not just throw if the mode is invalid, you would anyway fail on the first attempt to call a method on the controll at line 131?
Pavel Feldman
Comment 3 2013-04-02 07:16:51 PDT
Comment on attachment 195984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195984&action=review > Source/WebCore/inspector/front-end/TimelineOverviewPane.js:410 > + getWindowTimes: function(windowLeft, windowRight) windowTimes (since you touch it...)
Andrey Kosyakov
Comment 4 2013-04-02 07:37:25 PDT
Comment on attachment 195984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195984&action=review >> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:148 >> + return null; > > Why not just throw if the mode is invalid, you would anyway fail on the first attempt to call a method on the controll at line 131? Fixed! >> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:410 >> + getWindowTimes: function(windowLeft, windowRight) > > windowTimes (since you touch it...) Fixed as well.
Andrey Kosyakov
Comment 5 2013-04-02 07:43:03 PDT
Committed r147431: <http://trac.webkit.org/changeset/147431>
Note You need to log in before you can comment on or make changes to this bug.