Bug 113708 - Web Inspector: [Timeline] unify logic for 3 overview modes in Timeline
Summary: Web Inspector: [Timeline] unify logic for 3 overview modes in Timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on: 113705
Blocks: 113501
  Show dependency tree / graph
 
Reported: 2013-04-01 10:04 PDT by Andrey Kosyakov
Modified: 2013-04-02 07:43 PDT (History)
8 users (show)

See Also:

Attachments
Patch (13.07 KB, patch)
2013-04-01 10:09 PDT, Andrey Kosyakov 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2013-04-01 10:04:17 PDT 
Now that the 3 modes implement a common interface, remove all custom logic in overview pane itself and handle them in a consistent manner.
Comment 1 Andrey Kosyakov 2013-04-01 10:09:20 PDT 
Created attachment 195984 [details]
Patch
Comment 2 Yury Semikhatsky 2013-04-02 07:07:52 PDT 
Comment on attachment 195984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195984&action=review

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:148
> +        return null;

Why not just throw if the mode is invalid, you would anyway fail on the first attempt to call a method on the controll at line 131?
Comment 3 Pavel Feldman 2013-04-02 07:16:51 PDT 
Comment on attachment 195984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195984&action=review

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:410
> +    getWindowTimes: function(windowLeft, windowRight)

windowTimes (since you touch it...)
Comment 4 Andrey Kosyakov 2013-04-02 07:37:25 PDT 
Comment on attachment 195984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195984&action=review

>> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:148
>> +        return null;
> 
> Why not just throw if the mode is invalid, you would anyway fail on the first attempt to call a method on the controll at line 131?

Fixed!

>> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:410
>> +    getWindowTimes: function(windowLeft, windowRight)
> 
> windowTimes (since you touch it...)

Fixed as well.
Comment 5 Andrey Kosyakov 2013-04-02 07:43:03 PDT 
Committed r147431: <http://trac.webkit.org/changeset/147431>