How to reproduce: 1. Open http://www.tpri.com/MenuTest/menu.html 2. See that the live output (bottom menu) doesn't match the reference rendering (top menu) This is a confirmed regression from http://trac.webkit.org/changeset/142152 as rolling it out locally removes the issue. I didn't dig into the exact issue so the title is intentionally vague.
Created attachment 196402 [details] Patch
Comment on attachment 196402 [details] Patch Attachment 196402 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17388210 New failing tests: fast/inline/inline-with-empty-inline-children.html
Created attachment 196411 [details] Archive of layout-test-results from gce-cr-linux-07 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Created attachment 196412 [details] Patch
Comment on attachment 196412 [details] Patch r=me
Comment on attachment 196412 [details] Patch Rejecting attachment 196412 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 196412, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: out of 2 hunks FAILED -- saving rejects to file LayoutTests/fast/inline/inline-with-empty-inline-children-expected.txt.rej patching file LayoutTests/fast/inline/inline-with-empty-inline-children.html Hunk #1 FAILED at 4. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/fast/inline/inline-with-empty-inline-children.html.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'David Hyatt']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://webkit-commit-queue.appspot.com/results/17493085
Comment on attachment 196412 [details] Patch Clearing flags on attachment: 196412 Committed r147662: <http://trac.webkit.org/changeset/147662>
All reviewed patches have been landed. Closing bug.
This broke: fast/regions/fixed-pos-elem-in-region.html Can you please have a look?
Re-opened since this is blocked by bug 113955
Created attachment 196583 [details] Patch
(In reply to comment #9) > This broke: fast/regions/fixed-pos-elem-in-region.html > > Can you please have a look? This passes for me locally using both chromium-linux and Qt builds. I strongly suspect temporary flakiness on the bots was to blame.
> This passes for me locally using both chromium-linux and Qt builds. I strongly suspect temporary flakiness on the bots was to blame. That was not a flaky test. It failed at least twice on the WebKit2 bots.
(In reply to comment #13) > > This passes for me locally using both chromium-linux and Qt builds. I strongly suspect temporary flakiness on the bots was to blame. > > That was not a flaky test. It failed at least twice on the WebKit2 bots. The Mac-WK2 EWS runs reference tests and is green on this patch so I'm going to reland it..
Created attachment 196730 [details] Patch
Comment on attachment 196730 [details] Patch Attachment 196730 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17524433 New failing tests: platform/mac-wk2/plugins/npp-setwindow-called-on-scroll.html
Created attachment 196737 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Comment on attachment 196730 [details] Patch Clearing flags on attachment: 196730 Committed r147850: <http://trac.webkit.org/changeset/147850>
Reverted r147850 for reason: Changeset crossed paths with 147505, which is the same fix. Committed r147939: <http://trac.webkit.org/changeset/147939>