Bug 113704 - r147324 broke the world
Summary: r147324 broke the world
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 08:47 PDT by Mark Hahnenberg
Modified: 2013-04-01 09:07 PDT (History)
0 users

See Also:

Attachments
Patch (4.24 KB, patch)
2013-04-01 08:54 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-04-01 08:47:52 PDT 
Build fix is significant enough to warrant a quick review. Thanks for nothing, EWS.
Comment 1 Mark Hahnenberg 2013-04-01 08:54:26 PDT 
Created attachment 195977 [details]
Patch
Comment 2 Mark Lam 2013-04-01 08:57:33 PDT 
Comment on attachment 195977 [details]
Patch

LGTM.  The changes are superficial.
Comment 3 Mark Hahnenberg 2013-04-01 08:59:21 PDT 
Committed r147330: <http://trac.webkit.org/changeset/147330>
Comment 4 Darin Adler 2013-04-01 09:07:28 PDT 
Comment on attachment 195977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195977&action=review

> Source/JavaScriptCore/heap/SuperRegion.cpp:33
> +const uint64_t SuperRegion::s_fixedHeapMemoryPoolSize = 4LLU * 1024LLU * static_cast<uint64_t>(MB);

I’m not sure the changes to add LLU are portable enough (since they might be bigger or smaller than uint64_t on various platforms), and they probably also are not needed since you’ve casted MB to uint64_t.