Bug 113699 – [ATK] build fails when accessibility is turned off

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Ed Bartosh]

Running build with --minimal while working on #113641 and #113660 triggered this build failure:

Source/WebCore/editing/atk/FrameSelectionAtk.cpp:28:40: fatal error: WebKitAccessibleWrapperAtk.h: No such file or directory
compilation terminated.
[ 80%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/page/efl/EventHandlerEfl.cpp.o
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/editing/atk/FrameSelectionAtk.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2
make: *** [all] Error 2

Compilation exited abnormally with code 2 at Mon Apr  1 14:46:55

[Ed Bartosh]

Created attachment 195961 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 195961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195961&action=review

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:24
>  #include "FrameSelection.h"

WebKit coding style says that *all implementation files must #include the primary header second, just after "config.h"*

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:-26
> -

Do not touch file unrelated to patch.

[Gyuyoung Kim]

(In reply to comment #2)

> Do not touch file unrelated to patch.

s/file/line/g

[Ed Bartosh]

Created attachment 196187 [details]
Updated according to reviewer suggestions.

[Gyuyoung Kim]

Comment on attachment 196187 [details]
Updated according to reviewer suggestions.

View in context: https://bugs.webkit.org/attachment.cgi?id=196187&action=review

LGTM otherwise.

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:23
> +#if HAVE(ACCESSIBILITY)

It would be good if you add a new line below.

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:111
> +#endif // HAVE(ACCESSIBILITY)

It would be good if you add a new line above.

[Ed Bartosh]

Created attachment 196403 [details]
Patch

Updated according to review comments.

[WebKit Review Bot]

Comment on attachment 196403 [details]
Patch

Clearing flags on attachment: 196403

Committed r147615: <http://trac.webkit.org/changeset/147615>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.