Bug 113699 - [ATK] build fails when accessibility is turned off
Summary: [ATK] build fails when accessibility is turned off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 04:55 PDT by Ed Bartosh
Modified: 2013-04-04 01:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2013-04-01 05:13 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Updated according to reviewer suggestions. (1.38 KB, patch)
2013-04-02 11:05 PDT, Ed Bartosh 		gyuyoung.kim: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
Patch (1.38 KB, patch)
2013-04-03 13:04 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Bartosh 2013-04-01 04:55:59 PDT 
Running build with --minimal while working on #113641 and #113660 triggered this build failure:

Source/WebCore/editing/atk/FrameSelectionAtk.cpp:28:40: fatal error: WebKitAccessibleWrapperAtk.h: No such file or directory
compilation terminated.
[ 80%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/page/efl/EventHandlerEfl.cpp.o
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/editing/atk/FrameSelectionAtk.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2
make: *** [all] Error 2

Compilation exited abnormally with code 2 at Mon Apr  1 14:46:55
Comment 1 Ed Bartosh 2013-04-01 05:13:44 PDT 
Created attachment 195961 [details]
Patch
Comment 2 Gyuyoung Kim 2013-04-01 18:04:42 PDT 
Comment on attachment 195961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195961&action=review

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:24
>  #include "FrameSelection.h"

WebKit coding style says that *all implementation files must #include the primary header second, just after "config.h"*

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:-26
> -

Do not touch file unrelated to patch.
Comment 3 Gyuyoung Kim 2013-04-01 18:05:18 PDT 
(In reply to comment #2)

> Do not touch file unrelated to patch.

s/file/line/g
Comment 4 Ed Bartosh 2013-04-02 11:05:31 PDT 
Created attachment 196187 [details]
Updated according to reviewer suggestions.
Comment 5 Gyuyoung Kim 2013-04-02 21:28:27 PDT 
Comment on attachment 196187 [details]
Updated according to reviewer suggestions.

View in context: https://bugs.webkit.org/attachment.cgi?id=196187&action=review

LGTM otherwise.

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:23
> +#if HAVE(ACCESSIBILITY)

It would be good if you add a new line below.

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:111
> +#endif // HAVE(ACCESSIBILITY)

It would be good if you add a new line above.
Comment 6 Ed Bartosh 2013-04-03 13:04:49 PDT 
Created attachment 196403 [details]
Patch

Updated according to review comments.
Comment 7 WebKit Review Bot 2013-04-04 01:37:48 PDT 
Comment on attachment 196403 [details]
Patch

Clearing flags on attachment: 196403

Committed r147615: <http://trac.webkit.org/changeset/147615>
Comment 8 WebKit Review Bot 2013-04-04 01:37:53 PDT 
All reviewed patches have been landed.  Closing bug.