Bug 113698 - When a line has two size texts, the bigger text's under line which position is under is too far from its bottom.
Summary: When a line has two size texts, the bigger text's under line which position i...
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 04:39 PDT by Yuki Sekiguchi
Modified: 2016-05-03 13:54 PDT (History)
7 users (show)

See Also:


Attachments
reproduced html content (361 bytes, text/html)
2013-04-01 04:39 PDT, Yuki Sekiguchi
no flags Details
Patch (15.33 KB, patch)
2013-04-01 04:55 PDT, Yuki Sekiguchi
mmaxfield: review-
Details | Formatted Diff | Diff
Edge (13.15 KB, image/png)
2016-05-03 13:48 PDT, Myles C. Maxfield
no flags Details
Chrome (164.88 KB, image/png)
2016-05-03 13:48 PDT, Myles C. Maxfield
no flags Details
Firefox (165.23 KB, image/png)
2016-05-03 13:49 PDT, Myles C. Maxfield
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuki Sekiguchi 2013-04-01 04:39:24 PDT
Created attachment 195955 [details]
reproduced html content

You need to define ENABLE_CSS3_TEXT, so nightly build cannot reproduce this.

In the attached content, the underline of "big p" is far from its bottom.
Comment 1 Yuki Sekiguchi 2013-04-01 04:55:05 PDT
Created attachment 195956 [details]
Patch
Comment 2 Yuki Sekiguchi 2013-04-01 17:57:48 PDT
Hi Levi,

Could you review this patch?
This patch fix the bug which you reviewed at the following commit:
http://trac.webkit.org/changeset/146104
Comment 3 Myles C. Maxfield 2016-05-03 13:48:43 PDT
Created attachment 278018 [details]
Edge
Comment 4 Myles C. Maxfield 2016-05-03 13:48:55 PDT
Created attachment 278019 [details]
Chrome
Comment 5 Myles C. Maxfield 2016-05-03 13:49:07 PDT
Created attachment 278020 [details]
Firefox
Comment 6 Myles C. Maxfield 2016-05-03 13:49:50 PDT
As you can see from the screenshots I just uploaded, all the browsers vary both the position and thickness of underlines based on font size.
Comment 7 Myles C. Maxfield 2016-05-03 13:51:43 PDT
This patch (195956) does not apply any more.
Comment 8 Myles C. Maxfield 2016-05-03 13:54:01 PDT
Comment on attachment 195956 [details]
Patch

We need to make sure that the following content places the two underlines differently with different thicknesses:

<p style="text-decoration: underline; font-size: 90px;">Hello</p>
<p style="text-decoration: underline; font-size: 10px;">Hello</p>

The patch, as its posted, does not appear to do that (although I can't tell for sure because I can no longer apply it)