Bug 113685 - [EFL][CMAKE] Move MOZ_X11 definition from OptionsCommon to OptionsEfl
Summary: [EFL][CMAKE] Move MOZ_X11 definition from OptionsCommon to OptionsEfl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 00:35 PDT by Carlos Garcia Campos
Modified: 2013-04-02 00:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2013-04-01 00:37 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-04-01 00:35:33 PDT 
MOZ_X11 is added unconditionally in OptionsCommon for UNIX platforms, but not all UNIX platforms use X11 for plugins, BlackBerry doesn't. The only port using cmake that uses X11 is EFL and it already has checks for X11, so we can just move the definition to OptionsEfl.
Comment 1 Carlos Garcia Campos 2013-04-01 00:37:33 PDT 
Created attachment 195935 [details]
Patch
Comment 2 Martin Robinson 2013-04-01 08:03:13 PDT 
Comment on attachment 195935 [details]
Patch

Seems reasonable.
Comment 3 Carlos Garcia Campos 2013-04-01 08:24:01 PDT 
Thanks for the review Martin! could someone from EFL confirm this is sane before I land this, please?
Comment 4 Ryuan Choi 2013-04-01 20:31:33 PDT 
(In reply to comment #3)
> Thanks for the review Martin! could someone from EFL confirm this is sane before I land this, please?

I believe that it should be fine for EFL.
Comment 5 Carlos Garcia Campos 2013-04-01 23:36:28 PDT 
Comment on attachment 195935 [details]
Patch

Thanks!
Comment 6 WebKit Review Bot 2013-04-02 00:09:36 PDT 
Comment on attachment 195935 [details]
Patch

Clearing flags on attachment: 195935

Committed r147396: <http://trac.webkit.org/changeset/147396>
Comment 7 WebKit Review Bot 2013-04-02 00:09:41 PDT 
All reviewed patches have been landed.  Closing bug.