113682 – Web Inspector: Flame Chart. Extract item to coordinates conversion into a separate function.

RESOLVED FIXED 113682

Web Inspector: Flame Chart. Extract item to coordinates conversion into a separate function.

https://bugs.webkit.org/show_bug.cgi?id=113682

Summary Web Inspector: Flame Chart. Extract item to coordinates conversion into a sep...

Ilya Tikhonovsky

Reported 2013-04-01 00:22:13 PDT

There are two places where we calculate coordinates for an item. One is in method draw, the other is in getPopoverAnchor. It is easy to make a mistake if we need to change the logic or introduce an offset. So we need a single function for that.

Attachments
Patch (9.37 KB, patch) 2013-04-01 00:43 PDT, Ilya Tikhonovsky	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2013-04-01 00:43:41 PDT

Created attachment 195937 [details] Patch

Ilya Tikhonovsky

Comment 2 2013-04-01 01:11:44 PDT

Committed r147308: <http://trac.webkit.org/changeset/147308>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware All

OS All

Product WebKit

Component Web Inspector (Deprecated)

Assignee

Ilya Tikhonovsky

Reported

2013-04-01 00:22 PDT

Modified

2013-04-01 01:11 PDT History

CC List

8 users Show

URL

Keywords

Depends on

Blocks