Bug 113682 - Web Inspector: Flame Chart. Extract item to coordinates conversion into a separate function.
Summary: Web Inspector: Flame Chart. Extract item to coordinates conversion into a sep...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 00:22 PDT by Ilya Tikhonovsky
Modified: 2013-04-01 01:11 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.37 KB, patch)
2013-04-01 00:43 PDT, Ilya Tikhonovsky 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-04-01 00:22:13 PDT 
There are two places where we calculate coordinates for an item.
One is in method draw, the other is in getPopoverAnchor.
It is easy to make a mistake if we need to change the logic or introduce an offset.
So we need a single function for that.
Comment 1 Ilya Tikhonovsky 2013-04-01 00:43:41 PDT 
Created attachment 195937 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-04-01 01:11:44 PDT 
Committed r147308: <http://trac.webkit.org/changeset/147308>