Bug 113681 - Remove a couple of malloc from ExceptionBase construction
Summary: Remove a couple of malloc from ExceptionBase construction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-31 23:56 PDT by Benjamin Poulain
Modified: 2013-04-01 13:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2013-04-01 00:04 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-03-31 23:56:28 PDT 
Remove a couple of malloc from ExceptionBase construction
Comment 1 Benjamin Poulain 2013-04-01 00:04:14 PDT 
Created attachment 195931 [details]
Patch
Comment 2 Darin Adler 2013-04-01 01:13:04 PDT 
Comment on attachment 195931 [details]
Patch

Looks good. We also need to fix this so we don’t need to use String::number in cases like this; should format the number into a temporary buffer that can then be appended to the string, not a heap-allocated string.
Comment 3 Benjamin Poulain 2013-04-01 12:27:25 PDT 
(In reply to comment #2)
> (From update of attachment 195931 [details])
> Looks good. We also need to fix this so we don’t need to use String::number in cases like this; should format the number into a temporary buffer that can then be appended to the string, not a heap-allocated string.

Yep, this have been annoying me for a while but I have not got the time to fix it yet.

Thank you for the review.
Comment 4 WebKit Review Bot 2013-04-01 13:00:03 PDT 
Comment on attachment 195931 [details]
Patch

Clearing flags on attachment: 195931

Committed r147353: <http://trac.webkit.org/changeset/147353>
Comment 5 WebKit Review Bot 2013-04-01 13:00:06 PDT 
All reviewed patches have been landed.  Closing bug.