Bug 113680 – [css3-text] Parsing -webkit-hanging value for text-indent from css3-text

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Jaehun Lim]

The CSS text-indent property accepts the "hanging" values in CSS3.

Please refer:
http://dev.w3.org/csswg/css-text/#hanging

‘hanging’ means
"Inverts which lines are affected."

[Jaehun Lim]

Created attachment 195943 [details]
Patch

[Jaehun Lim]

Created attachment 195945 [details]
Patch

[Jaehun Lim]

Created attachment 196096 [details]
Patch

[Andreas Kling]

Comment on attachment 196096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196096&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2197
> +            // If CSS3_TEXT is disabled or text-indent has only one value(<length> | <perceantage>),
> +            // getPropertyCSSValue() returns CSSValue.

perceantage -> percentage

> Source/WebCore/css/StyleBuilder.cpp:2049
> +        TextIndentLine eachLineValue = TextIndentFirstLine;
> +        TextIndentType hangingValue = TextIndentNormal;

These are badly named, as they refer to one of two possible values in both cases.
I'd suggest something like:

TextIndentLine textIndentLineValue = RenderStyle::initialTextIndentLine();
TextIndentType textIndentTypeValue = RenderStyle::initialTextIndentType();

That way you also avoid repeating the initial values.

> Source/WebCore/rendering/style/StyleRareInheritedData.h:105
> +    unsigned m_textIndentType : 1; // TextIndentHanging

TextIndentHanging -> TextIndentType

[Jaehun Lim]

Created attachment 197196 [details]
Patch

[Jaehun Lim]

Comment on attachment 196096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196096&action=review

Thanks for your comments.

>> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2197
>> +            // getPropertyCSSValue() returns CSSValue.
> 
> perceantage -> percentage

Fixed.

>> Source/WebCore/css/StyleBuilder.cpp:2049
>> +        TextIndentType hangingValue = TextIndentNormal;
> 
> These are badly named, as they refer to one of two possible values in both cases.
> I'd suggest something like:
> 
> TextIndentLine textIndentLineValue = RenderStyle::initialTextIndentLine();
> TextIndentType textIndentTypeValue = RenderStyle::initialTextIndentType();
> 
> That way you also avoid repeating the initial values.

Fixed to use init functions and change names.

>> Source/WebCore/rendering/style/StyleRareInheritedData.h:105
>> +    unsigned m_textIndentType : 1; // TextIndentHanging
> 
> TextIndentHanging -> TextIndentType

Fixed with TextIndentEachLine -> TextIndentLine

[Build Bot]

Comment on attachment 197196 [details]
Patch

Attachment 197196 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17667034

New failing tests:
editing/unsupported-content/table-delete-003.html
editing/unsupported-content/list-type-before.html
editing/unsupported-content/table-type-before.html
editing/unsupported-content/table-delete-002.html
editing/unsupported-content/list-delete-001.html
editing/unsupported-content/list-type-after.html
editing/unsupported-content/list-delete-003.html
editing/unsupported-content/table-type-after.html
editing/unsupported-content/table-delete-001.html

[Build Bot]

Created attachment 197235 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2

[Jaehun Lim]

Created attachment 197417 [details]
Patch

[Andreas Kling]

Comment on attachment 197417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197417&action=review

r=me

> Source/WebCore/ChangeLog:12
> +        No new tests, this patch updates exisiting tests.

Typo, existing.

[Jaehun Lim]

Comment on attachment 197417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197417&action=review

Thanks.

>> Source/WebCore/ChangeLog:12
>> +        No new tests, this patch updates exisiting tests.
> 
> Typo, existing.

Fixed.

[Jaehun Lim]

Created attachment 197856 [details]
Patch

[Jaehun Lim]

Created attachment 197982 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 197982 [details]
Patch for landing

Clearing flags on attachment: 197982

Committed r148414: <http://trac.webkit.org/changeset/148414>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.